Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Passing wrong number of parameters results in a crash. #5465

Closed
DorpsGek opened this issue Feb 7, 2013 · 1 comment
Closed

Passing wrong number of parameters results in a crash. #5465

DorpsGek opened this issue Feb 7, 2013 · 1 comment
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)

Comments

@DorpsGek
Copy link
Member

DorpsGek commented Feb 7, 2013

Aphid opened the ticket and wrote:

Whenever a script tries to pass too many parameters through string concatenation, it might crash OpenTTD in some revisions:

The following script creates a string of 7 parameters, and then tries to concatenate three copies of it.
The squirrel checker will not pick up this programming error, because it thinks it's fine.

The failure then happens within openTTD itself, as an assertion failure in strings_func.h

Tested in 1.3.0 beta 64-bit windows, crash happens.
Also tested in trunk. r24976, crash happens.
Interestingly: This crash does NOT happen in stable 1.2.3 64-bit windows.

Attachments

Reported version: trunk
Operating system: All


This issue was imported from FlySpray: https://bugs.openttd.org/task/5465
@DorpsGek
Copy link
Member Author

DorpsGek commented Feb 8, 2013

Rubidium closed the ticket.

Reason for closing: Fixed

In r24982


This comment was imported from FlySpray: https://bugs.openttd.org/task/5465

@DorpsGek DorpsGek closed this as completed Feb 8, 2013
@DorpsGek DorpsGek added flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) bug labels Apr 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)
Projects
None yet
Development

No branches or pull requests

1 participant