Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New misc_flag to disable vehicle intro date randomization #5456

Closed
DorpsGek opened this issue Jan 29, 2013 · 5 comments
Closed

New misc_flag to disable vehicle intro date randomization #5456

DorpsGek opened this issue Jan 29, 2013 · 5 comments
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) patch from FlySpray This issue is in fact a Patch, but imported from FlySrpay

Comments

@DorpsGek
Copy link
Member

Supercheese opened the ticket and wrote:

Attached is a patch against r24948 that defines a new misc_flag for vehicles, EF_NO_RANDOM_INTRO_DATE, that if set will prevent the vehicle's introduction date from being randomized.

This is useful for introducing historically important vehicles (such as the first Montgolfier hot air balloon or the Wright Flyer) at the proper date, and useful for other purposes too (see: http://bugs.openttd.org/task/5086)

A few comments:

I'm not 100% sure when parentheses are needed and when they aren't, so I took the "add more" route, I hope that's not too big of an issue.

It seems that bit 7 is the last available bit for misc_flags...

Attachments

Reported version: trunk
Operating system: All


This issue was imported from FlySpray: https://bugs.openttd.org/task/5456
@DorpsGek
Copy link
Member Author

Supercheese wrote:

Here's an example grf with the flag set, a modified version of the Hot Air Balloon grf available from Bananas with the appropriate flag set. Intro date is date(1960,1,1) in NML.

Attachments


This comment was imported from FlySpray: https://bugs.openttd.org/task/5456#comment11929

@DorpsGek
Copy link
Member Author

frosch wrote:

As discussed in #5086, I don't think this is the right way to go at all.
You are heading for introducing stuff at the same time. Disabling randomisation is a really really stupid hack for that.


This comment was imported from FlySpray: https://bugs.openttd.org/task/5456#comment11934

@DorpsGek
Copy link
Member Author

Supercheese wrote:

My interest is not so much for introducing a set of vehicles at the same time, but for introducing the historical vehicles mentioned above at the appropriate date. For instance, the first Wright Flyer flew on December 17, 1903, but by 1904 the Wright brothers had already built a second Flyer, and by 1905 a third with different specifications. If a grf wanted to have the Wright Flyer introduced as close to December 17, 1903 as possible, with the randomization it could end up being introduced in OTTD as late as May 1905, far too late for the first or even second model Flyers.


This comment was imported from FlySpray: https://bugs.openttd.org/task/5456#comment11936

@DorpsGek
Copy link
Member Author

Alberth wrote:

Currently it is far too easy to confuse this idea with a hack to work around a proper solution for #5086.


This comment was imported from FlySpray: https://bugs.openttd.org/task/5456#comment11938

@DorpsGek
Copy link
Member Author

andythenorth closed the ticket.

Reason for closing: Won't implement

Disabling randomisation isn't a current goal :) OpenTTD simulates a highly realistic quantum universe, and vehicle intro dates are probabilistic accordingly ;)

Flyspray clean up, so closing.


This comment was imported from FlySpray: https://bugs.openttd.org/task/5456

@DorpsGek DorpsGek added flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) Vehicles patch from FlySpray This issue is in fact a Patch, but imported from FlySrpay labels Apr 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) patch from FlySpray This issue is in fact a Patch, but imported from FlySrpay
Projects
None yet
Development

No branches or pull requests

1 participant