Alberth wrote:

The nice thing about enumerations is that they behave like integers, you can use numbers like the airports as an index in an array. That should collapse your switches to a single line of code. If not, refactor duplicate code into a separate function.

I don't believe for a minute this patch actually works. Your new _settings_game variables are not getting initialized.

The load and save code is also missing. Try changing a few settings, and then saving the game, quit the program, then restart, and reload the save game. Similar problems will happen when you do this in MP (a multi-player network game).

Coding style does not even look right, we use TAB for indenting and a space between the keyword "switch" and the opening parenthesis.

Last but not least, when you change catchment areas, all kinds of things change, stations do not accept types of cargo any more, industries stop delivering to you, stations that were merged cannot co-exist any more, etc. I don't see any of that back in your patch.
I am not that well informed about that part of the code, but it would be a miracle when you literally don't have to do anything.

This comment was imported from FlySpray: https://bugs.openttd.org/task/5453#comment11913

frosch wrote:

Also note that airport catchment areas are defined by NewGRF.
Settings are not exactly useful for something than can be changed and overwritten by NewGRF.

This comment was imported from FlySpray: https://bugs.openttd.org/task/5453#comment11914

Zuu wrote:

You have removed eg. CA_TRAIN and changed some code, but not all places which uses this constant. For example ScriptStation::GetCoverageRadius is left unchanged. This method is exposed to AIs and Game Scripts. I'm surprised that your code compiles. Maybe you have compiled a build with AI + GameScript disabled?

This comment was imported from FlySpray: https://bugs.openttd.org/task/5453#comment11915

ComLock wrote:

I did mention I'm not really a c++ programmer... Also this was my first look at the openttd code... So I don't know it at all.
So please have some positivity...

Supercheese wrote:
Airport catchments are already configurable via grf: http://newgrf-specs.tt-wiki.net/wiki/NM ... properties

My reply
Aha, so I guess I should add more newgrf support, rather than more settings.

Yes, I did not test savegame and MP.

This comment was imported from FlySpray: https://bugs.openttd.org/task/5453#comment11924

ComLock wrote:

Here's a screenshot showing it actually does work.

I'll see if I can do it newgrf style instead.

Attachments

• catchment_as_setting.png (613.00 KiB)

This comment was imported from FlySpray: https://bugs.openttd.org/task/5453#comment11931

frosch wrote:

I am not convinced this feature is particulary useful at all. Why do you want to change the catchment area, and even with a GUI setting?

From a gameplay POV you can get any arbitrary catchment area anyway by joining multiple station tiles.

From a user interface POV you add a dozen setting which 1% of users might be interested to try them once.

From a code POV any attempt at coding this can only be inconsistent. Airports are dynamically added by NewGRF, so any selection of them in the settings is pointless. And adding the other station types without airports is just weird as well. Besides you might want different catchment areas for different station types or similar.

This comment was imported from FlySpray: https://bugs.openttd.org/task/5453#comment11935

frosch wrote:

We've discussed this briefly in a small round of devs, and don't think this feature is viable.

This comment was imported from FlySpray: https://bugs.openttd.org/task/5453#comment11937

frosch closed the ticket.

Reason for closing: Won't implement

This comment was imported from FlySpray: https://bugs.openttd.org/task/5453