Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Crash on viewing vehicle orders #5446

Closed
DorpsGek opened this issue Jan 22, 2013 · 8 comments
Closed

Crash on viewing vehicle orders #5446

DorpsGek opened this issue Jan 22, 2013 · 8 comments
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)

Comments

@DorpsGek
Copy link
Member

Aphid opened the ticket and wrote:

Beta 1.3.0.

Certain conditions may cause OpenTTD to crash when viewing a particular vehicle's orders.

Possible example is a multiplayer server with NewGRFS OGFX+Industries and EGRVTS2. Buying a Mettler Refrigerated truck, giving it orders, and then refitting it to fruit causes a crash when viewing the order list.

The exact reason why is unknown to me.

Exception: E1212012
Location: 000007FEFDBFCACD
Message: NOT_REACHED triggered at line 256 of ..\src\strings.cpp

Attachments

Reported version: other
Operating system: All

This issue was imported from FlySpray: https://bugs.openttd.org/task/5446
@DorpsGek
Copy link
Member Author

Aphid wrote:

While the client application crashed, the server seems unaffected.

Edit 1: If a vehicle causes this crash, any clones of this vehicle will cause the same crash.

This comment was imported from FlySpray: https://bugs.openttd.org/task/5446#comment11891

@DorpsGek
Copy link
Member Author

peter1138 wrote:

Can you upload a savegame please.

This comment was imported from FlySpray: https://bugs.openttd.org/task/5446#comment11892

@DorpsGek
Copy link
Member Author

Aphid wrote:

See attached file.

Attachments

This comment was imported from FlySpray: https://bugs.openttd.org/task/5446#comment11896

@DorpsGek
Copy link
Member Author

Aphid wrote:

See attached file.

Attachments

This comment was imported from FlySpray: https://bugs.openttd.org/task/5446#comment11897

@DorpsGek
Copy link
Member Author

peter1138 wrote:

It's a Transfer & no load order with a cargo refit, which seems to be invalid...

This comment was imported from FlySpray: https://bugs.openttd.org/task/5446#comment11900

@DorpsGek
Copy link
Member Author

peter1138 wrote:

Setting an order refit doesn't check for a no-load order. It is restricted only in the UI, so if the game is laggy it is possible to set an order refit in the time between switching to no-load and the UI updating. This patch should fix that, but it won't fix the existing game.

Attachments

This comment was imported from FlySpray: https://bugs.openttd.org/task/5446#comment11901

@DorpsGek
Copy link
Member Author

peter1138 wrote:

To fix your game you can sell the vehicle and replace it.

This comment was imported from FlySpray: https://bugs.openttd.org/task/5446#comment11903

@DorpsGek
Copy link
Member Author

peter1138 closed the ticket.

Reason for closing: Fixed

Fixed in r24936

This comment was imported from FlySpray: https://bugs.openttd.org/task/5446

@DorpsGek DorpsGek added flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) Vehicles labels Apr 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@DorpsGek