Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vehicles: take refitted capacity into account in buy menu #5437

Closed
DorpsGek opened this issue Jan 5, 2013 · 2 comments
Closed

Vehicles: take refitted capacity into account in buy menu #5437

DorpsGek opened this issue Jan 5, 2013 · 2 comments
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)

Comments

@DorpsGek
Copy link
Member

DorpsGek commented Jan 5, 2013

George opened the ticket and wrote:

R24865

In buy vehicle window when vehicles are sorted by capacity and filtered by cargo type, value of capacity for default cargo is used.
for example:
84 crates of goods
60 tons of food (wagon # 2)
52 crates of goods
But when the wagon # 2 is refited to goods, it gets capacity equal to 120 crates of goods, which is more than 84 crates of goods.
It would be nice to display refited capacity in this case (when a filter by cargo is applied), like this
120 crates of goods (wagon # 2)
84 crates of goods
52 crates of goods

Reported version: trunk
Operating system: All


This issue was imported from FlySpray: https://bugs.openttd.org/task/5437
@DorpsGek
Copy link
Member Author

krinn wrote:

I could answer that one as i've been told why :)

openttd cannot know some vehicle properties by the newGRF until the vehicle is created. So to fill up the value you are seeking, openttd would need to create one vehicle of each type, and record all properties once built to keep track of them.
Not something undoable, but until one create a caching properties system, you will never seen it happen.


This comment was imported from FlySpray: https://bugs.openttd.org/task/5437#comment11870

@DorpsGek DorpsGek added flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) Vehicles labels Apr 7, 2018
@TrueBrain
Copy link
Member

Very complex because of NewGRFs (as explained, and more). I understand the roadmap, but I see no room for this currently.

Of course we welcome a patch that implements this properly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)
Projects
None yet
Development

No branches or pull requests

2 participants