Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a warning to AI/GSCompany.GetBankBalance for integer overflow #5410

Closed
DorpsGek opened this issue Dec 27, 2012 · 2 comments
Closed

Add a warning to AI/GSCompany.GetBankBalance for integer overflow #5410

DorpsGek opened this issue Dec 27, 2012 · 2 comments
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)

Comments

@DorpsGek
Copy link
Member

krinn opened the ticket and wrote:

I think it would be great to add a warning in the API documentation of at least that function to remind devs about the integer overflow.
The thread i've made will be good for all active AIs devs, but will be lost after some times and new AI devs won't get the warning.
see: http://www.tt-forums.net/viewtopic.php?f=65&t=63754

It wound't kill us to add this to the API documentation as a reminder for this (in my opinion) highly common and easy hole to fall in.

Reported version: Version?
Operating system: All

This issue was imported from FlySpray: https://bugs.openttd.org/task/5410
@DorpsGek
Copy link
Member Author

DorpsGek commented Nov 9, 2014

frosch closed the ticket.

Reason for closing: Fixed

in r26585

This comment was imported from FlySpray: https://bugs.openttd.org/task/5410

@DorpsGek DorpsGek closed this as completed Nov 9, 2014
@DorpsGek
Copy link
Member Author

DorpsGek commented Nov 9, 2014

frosch wrote:

OpenTTD 1.5 will do all squirrel stuff with 64 bit integers.

This comment was imported from FlySpray: https://bugs.openttd.org/task/5410#comment13622

@DorpsGek DorpsGek added flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) enhancement labels Apr 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@DorpsGek