Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The Clone vehicle button should share orders by default #5407

Closed
DorpsGek opened this issue Dec 26, 2012 · 5 comments
Closed

The Clone vehicle button should share orders by default #5407

DorpsGek opened this issue Dec 26, 2012 · 5 comments
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)

Comments

@DorpsGek
Copy link
Member

eshieldx opened the ticket and wrote:

Hello,

I've ran into 1 annoying bug: When I clone a vehicle with shared orders only list content is copied ... instead of being linked to shared orders. So I have to link it manually for all newly cloned vehicles.

Sorry for my English.

P.S: I hope this bug will be fixed in beta2.

EDIT: See https://secure.openttd.org/bugs/task/5407# comment11814

Attachments

Reported version: trunk
Operating system: All


This issue was imported from FlySpray: https://bugs.openttd.org/task/5407
@DorpsGek
Copy link
Member Author

Terkhen wrote:

Try to clone using Ctrl+Click. Click only clones the vehicle, but it does not share the orders by default. IIRC it is explained on a tooltip, but it is one of those "hidden" features.


This comment was imported from FlySpray: https://bugs.openttd.org/task/5407#comment11801

@DorpsGek
Copy link
Member Author

eshieldx wrote:

It really works, thanks a lot, Jose!

I think it's a very wrong behavior because cloning means 1-to-1 copy >without< any local changes.

I believe there are 2 solutions:

  1. Clone 1-to-1 without fancy explicit stuff.
  2. Rename button "Clone vehicle" to "Make a copy of a vehicle with random set of properties". That will be fair enough.

IMHO, by default, it will be better to clone 1-to-1.

If somebody doesn't want to make an exact copy he should use Ctrl-Click. Isn't it that obvious?


This comment was imported from FlySpray: https://bugs.openttd.org/task/5407#comment11814

@DorpsGek
Copy link
Member Author

Terkhen wrote:

I'm editing this task to make it a feature request, pointing to your comment.


This comment was imported from FlySpray: https://bugs.openttd.org/task/5407#comment11815

@DorpsGek
Copy link
Member Author

andythenorth wrote:

This shouldn't be changed. Putting aside the implications of changing behaviour and pissing off thousands off players...

The current clone is correct. It creates an exact copy. The source for the clone is always unchanged by the clone.

In the case that the source for the clone doesn't have shared orders, making shared orders would modify the source. That's not correct for an exact copy.


This comment was imported from FlySpray: https://bugs.openttd.org/task/5407#comment12865

@DorpsGek
Copy link
Member Author

andythenorth closed the ticket.

Reason for closing: Won't implement

Current behaviour is expected behaviour.


This comment was imported from FlySpray: https://bugs.openttd.org/task/5407

@DorpsGek DorpsGek added Core flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) labels Apr 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)
Projects
None yet
Development

No branches or pull requests

1 participant