Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changing bridge type steals all roads/trams on it. #5389

Closed
DorpsGek opened this issue Dec 13, 2012 · 2 comments
Closed

Changing bridge type steals all roads/trams on it. #5389

DorpsGek opened this issue Dec 13, 2012 · 2 comments
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)

Comments

@DorpsGek
Copy link
Member

adf88 opened the ticket and wrote:

Consider a bridge with booth roads and tram tracks on it, but having different owners. When the bridge owner changes type of the bridge, all the roads and tram tracks becomes owned by him/her, previous ownership is ignored.

Besides of giving ability to steal someone's roads, the bug also breaks infrastructure statistics.

Steps to reproduce:
- start an MP game
- player A builds a road bridge
- player B puts tram tracks on it
- player A tries to remove tram tracks and fails - tracks are owned by the player B
- player A changes the type of the bridge
- player A tries to remove tram tracks and succeeds

Fix-patch attached.

Attachments

Reported version: trunk
Operating system: All

This issue was imported from FlySpray: https://bugs.openttd.org/task/5389
@DorpsGek
Copy link
Member Author

frosch wrote:

Made the roadtype owners parameters of MakeRoadBridgeRamp to make it more obvious that it has these sideeffects.

This comment was imported from FlySpray: https://bugs.openttd.org/task/5389#comment11867

@DorpsGek
Copy link
Member Author

frosch closed the ticket.

Reason for closing: Fixed

in r24912. Thanks for the patch!

This comment was imported from FlySpray: https://bugs.openttd.org/task/5389

@DorpsGek DorpsGek added Core flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) labels Apr 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@DorpsGek