Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Moving Options in Message Settings Screen to Advanced Settings Screen #5361

Closed
DorpsGek opened this issue Nov 10, 2012 · 3 comments
Closed

Moving Options in Message Settings Screen to Advanced Settings Screen #5361

DorpsGek opened this issue Nov 10, 2012 · 3 comments
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) patch from FlySpray This issue is in fact a Patch, but imported from FlySrpay

Comments

@DorpsGek
Copy link
Member

Eagle_rainbow opened the ticket and wrote:

Here is a series of patches which moves the message settings window to the advanced settings screen (for details also refer to http://www.tt-forums.net/viewtopic.php?f=32&t=63164# p1052664).
General idea was to first make the settings in the IniGroup news_display accessible via the settingsgen approach (mergenewsoptions-0001-addsettings-v1-against-r24676.patch). To make it 100% compliant to this approach, new setting variables are introduced. Afterwards, these settings get added to a page below "Interface" on the advanced settings screen (mergenewsoptions-0002-addtoadvsettingsscreen-v1-against-r24676.patch) being visible only in "advanced mode". The next patch (mergenewsoptions-0003-adjreferences-v1-against-r24676.patch) adjusts the news logic to the new variables. On that course, locations are identified and marked which need to be cleaned up once the message settings screen is being removed. Cleaning up the message settings screen from the toolbar and further obsolete entries is being done with patch mergenewsoptions-0004-cleanup-v1-against-r24676.patch . Finally, also the option "coloured news paper since year" is being moved to the new "news" page on the advanced settings screen with patch mergenewsoptions-0005-colourednewspaper-v1-against-r24676.patch .
Finally, there's also a screenshot attached, now showing the new "news" page on the advanced setting screen.

I have split this rather large patch into smaller logical chunks to better allow reviewing. As their names suggest, all patches are against trunk revision 24676 and need to be applied in the sequence as mentioned above (patch queue).

Attachments

Reported version: trunk
Operating system: All

This issue was imported from FlySpray: https://bugs.openttd.org/task/5361
@DorpsGek
Copy link
Member Author

DorpsGek commented Dec 8, 2012

Eagle_rainbow wrote:

A discussion via email with frosch brought some insight on the lifecycle of localized strings in my case. Here's a new version of the patchset which incorporates the discussion.
Moreover, I have updated the patchset to the current revision (r24799).

Attachments

This comment was imported from FlySpray: https://bugs.openttd.org/task/5361#comment11742

@DorpsGek
Copy link
Member Author

frosch wrote:

Implemented in r24842 to 24845. Thanks for the diffs, though I think in the end I changed almost everything. But it was still helpful to see what stuff needs touching.

This comment was imported from FlySpray: https://bugs.openttd.org/task/5361#comment11779

@DorpsGek
Copy link
Member Author

frosch closed the ticket.

Reason for closing: Implemented

in r24842 to r24845

This comment was imported from FlySpray: https://bugs.openttd.org/task/5361

@DorpsGek DorpsGek added Core flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) patch from FlySpray This issue is in fact a Patch, but imported from FlySrpay labels Apr 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) patch from FlySpray This issue is in fact a Patch, but imported from FlySrpay
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@DorpsGek