Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Network window widget enums in script_window.hpp #5353

Closed
DorpsGek opened this issue Nov 3, 2012 · 4 comments
Closed

Network window widget enums in script_window.hpp #5353

DorpsGek opened this issue Nov 3, 2012 · 4 comments
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)

Comments

@DorpsGek
Copy link
Member

DorpsGek commented Nov 3, 2012

Yexo opened the ticket and wrote:

I don't think it's possible for a GameScript to run at any point in time any of the network-related windows is opened, so I don't see why the widgets of these windows are exported.

Reported version: trunk
Operating system: All


This issue was imported from FlySpray: https://bugs.openttd.org/task/5353
@DorpsGek
Copy link
Member Author

DorpsGek commented Nov 3, 2012

Eagle_rainbow wrote:

see also script/api/script_window.hpp, enum NetworkGameWidgets (~line 1534 there)


This comment was imported from FlySpray: https://bugs.openttd.org/task/5353#comment11652

@DorpsGek
Copy link
Member Author

DorpsGek commented Nov 3, 2012

frosch wrote:

I would hope that that file is automatically generated at some point, instead of maintained manually (which does not exactly happen currently).

I don't see the need to manually exclude windows from that. Why not just generate all?


This comment was imported from FlySpray: https://bugs.openttd.org/task/5353#comment11654

@DorpsGek
Copy link
Member Author

DorpsGek commented Nov 3, 2012

Eagle_rainbow wrote:

I was working on the removal of the edit box for the client name on the network game list screen. There, I wanted to get rid of the enum constant WID_NG_CLIENT and stumbled over this reference in script/api/script_window.hpp. As this is an API that is made public, I had my thoughts about removing this constant and thus making an incompatible change to some 3rd party consumer. That's why I pinged Yexo on IRC. He was puzzled that this class is exposed at all, but couldn't go into deep as it was very late already. That's why we have this reminder here.


This comment was imported from FlySpray: https://bugs.openttd.org/task/5353#comment11655

@DorpsGek
Copy link
Member Author

DorpsGek commented Nov 5, 2012

frosch closed the ticket.

Reason for closing: Fixed

in r24665 by adjusting the documentation


This comment was imported from FlySpray: https://bugs.openttd.org/task/5353

@DorpsGek DorpsGek closed this as completed Nov 5, 2012
@DorpsGek DorpsGek added Core flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) labels Apr 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)
Projects
None yet
Development

No branches or pull requests

1 participant