Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add filters to the build vehicle GUI #5292

Closed
DorpsGek opened this issue Sep 7, 2012 · 4 comments
Closed

Add filters to the build vehicle GUI #5292

DorpsGek opened this issue Sep 7, 2012 · 4 comments
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) patch from FlySpray This issue is in fact a Patch, but imported from FlySrpay

Comments

@DorpsGek
Copy link
Member

DorpsGek commented Sep 7, 2012

juanjo opened the ticket and wrote:

As listed in http://wiki.openttd.org/Todo_list, this patch adds a company setting to hide/show engines.

On the build vehicle window and autoreplace engines window you get by default a filtered list. This filtered list contains available and non-hidden vehicles for the company.

On the autoreplace window, there is a widget on the caption bar, so you can switch between filtered or complete list. The complete lists contains all available replacements, visible and also hidden ones.

On the build vehicle/available vehicles window, there is also a widget to show the complete list of engines. The ones drawn in black are available and not hidden. The ones in red are vehicles the company wants to keep hidden from filtered lists. And the others are unavailable (outdated/not introduced) and not hidden for the company. For toggling an engine visibility ctrl+click that engine on these windows.

Toggling visibility on autoreplacement window is not written. I don't see it as really necessary.
Unavailable vehicles are also shown so a company can hide an engine before it is introduced. It also lets players see all the engines that will be available through the game.

Full patch and a mercurial queue attached.

Attachments

Reported version: trunk
Operating system: All

This issue was imported from FlySpray: https://bugs.openttd.org/task/5292
@DorpsGek
Copy link
Member Author

DorpsGek commented Sep 7, 2012

juanjo wrote:

Somehow I didn't upload the correct full patch. The previous one was incomplete.

EDIT:
And after testing the patch, I decided to make some changes. The biggest one is about the colour legend:

black : available engine that is visible for company.
gray : available engine that is hidden for company.
orange: unavailable engine that when it becomes available will be visible for company.
red : unavailable engine that when it becomes available will be hidden for company.

Attachments

This comment was imported from FlySpray: https://bugs.openttd.org/task/5292#comment11499

@DorpsGek
Copy link
Member Author

Alberth wrote:

I don't think a user should be able to see in the future, so "engines that will become available" should be dropped from this patch.
The TODO task only speaks about hiding 'old' engines as well.

This comment was imported from FlySpray: https://bugs.openttd.org/task/5292#comment11524

@DorpsGek
Copy link
Member Author

juanjo wrote:

I have reordered the patches so applying patches 1-7 does as the TODO list task (as I understand it). The 8th one can be left out by now.

Anyway, I think that seeing all vehicles can also be considered. I'll post it as a suggestion on the forums to see if anybody else likes the idea. I don't see any problem in players seeing past and future vehicles. And I find useful to hide all desired engines at once instead of doing it one by one each time an engine becomes available.

Attachments

This comment was imported from FlySpray: https://bugs.openttd.org/task/5292#comment11533

@DorpsGek
Copy link
Member Author

DorpsGek commented Sep 7, 2014

Alberth closed the ticket.

Reason for closing: Implemented

in r26804 and r26805, thanks for the example command code.

This comment was imported from FlySpray: https://bugs.openttd.org/task/5292

@DorpsGek DorpsGek closed this as completed Sep 7, 2014
@DorpsGek DorpsGek added flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) Vehicles patch from FlySpray This issue is in fact a Patch, but imported from FlySrpay labels Apr 7, 2018
@DorpsGek DorpsGek mentioned this issue Apr 7, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) patch from FlySpray This issue is in fact a Patch, but imported from FlySrpay
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@DorpsGek