Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a 'sort by rating' capability to the town directory #5288

Closed
DorpsGek opened this issue Sep 2, 2012 · 4 comments
Closed

Add a 'sort by rating' capability to the town directory #5288

DorpsGek opened this issue Sep 2, 2012 · 4 comments
Labels
component: interface This is an interface issue flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) patch from FlySpray This issue is in fact a Patch, but imported from FlySrpay

Comments

@DorpsGek
Copy link
Member

DorpsGek commented Sep 2, 2012

sbr opened the ticket and wrote:

As propsed in http://wiki.openttd.org/Todo_list, this patch allow to sort the town directory by town's rating.
Towns without rating are sorted as worse than 'Appaling' to have them listed after rated towns.

Please find attached a patch against r24507.

Attachments

Reported version: trunk
Operating system: All


This issue was imported from FlySpray: https://bugs.openttd.org/task/5288
@DorpsGek
Copy link
Member Author

DorpsGek commented Sep 4, 2012

sbr wrote:

Forgot to add new widget to script/api/script_window.hpp.

Please find attached a patch against r24510.

Attachments


This comment was imported from FlySpray: https://bugs.openttd.org/task/5288#comment11495

@DorpsGek
Copy link
Member Author

Alberth wrote:

I don't think a button without text works. It looks like a panel used for resizing and does not invite to click on it.
See also the image.

A better solution can be to make a drop-down for selecting the column, and an up/down sort button, they are used at many places, for example in the industry directory window.

Attachments


This comment was imported from FlySpray: https://bugs.openttd.org/task/5288#comment11525

@DorpsGek
Copy link
Member Author

sbr wrote:

The first patch replace the two name and population buttons by an order button and a critera dropdown to sort towns.
The second patch add a new 'sort by rating' criteria; rated towns are always sorted "before" unrated towns.

Please find attached these two patches against r24543.

Attachments


This comment was imported from FlySpray: https://bugs.openttd.org/task/5288#comment11541

@DorpsGek
Copy link
Member Author

Alberth closed the ticket.

Reason for closing: Implemented

in r25094 and r25097


This comment was imported from FlySpray: https://bugs.openttd.org/task/5288

@DorpsGek DorpsGek added component: interface This is an interface issue flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) patch from FlySpray This issue is in fact a Patch, but imported from FlySrpay labels Apr 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: interface This is an interface issue flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) patch from FlySpray This issue is in fact a Patch, but imported from FlySrpay
Projects
None yet
Development

No branches or pull requests

1 participant