Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ctrl+Click on a sign in the sign list window to edit it #5284

Closed
DorpsGek opened this issue Sep 1, 2012 · 5 comments
Closed

Ctrl+Click on a sign in the sign list window to edit it #5284

DorpsGek opened this issue Sep 1, 2012 · 5 comments
Labels
component: interface This is an interface issue flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)

Comments

@DorpsGek
Copy link
Member

DorpsGek commented Sep 1, 2012

sbr opened the ticket and wrote:

This patch allow to edit a sign by Ctrl+Clicking it on the sign list window.
This permit to rename/delete a sign if it's not visible on the main viewport or if signs aren't displayed at all.

Please find attached a patch against r24502.

Attachments

Reported version: trunk
Operating system: All


This issue was imported from FlySpray: https://bugs.openttd.org/task/5284
@DorpsGek
Copy link
Member Author

DorpsGek commented Sep 2, 2012

planetmaker wrote:

I very much like the idea of being able to edit and delete signs from the sign list.

Comparing with other lists, a ctrl+click will open an extra viewport centred on the object though. Thus what about this:
ctrl+click opens the viewport
double click opens the edit capability


This comment was imported from FlySpray: https://bugs.openttd.org/task/5284#comment11481

@DorpsGek
Copy link
Member Author

DorpsGek commented Sep 2, 2012

sbr wrote:

Opening an extra viewport on Ctrl+click is consistent with the rest of the UI and should be the way to go. At first, I also found the use of double click to edit sign as a good idea.

However when double clicking, two events are send to the window: an OnClick(pt, widget, click_count = 1) for the first click of the double click and another OnClick(pt, widget, click_count = 2) when the second click of the double click occurs. Thus when double clicking on a sign, the main viewport is moved to the sign location before the opening of the edit window.

I've then split the patch in two parts, one for the Ctrl+click part and the other for the double click part.
I'll also try to find a way to launch the edit window without moving the main viewport.

Please find attached these two patches against r24508.

Attachments


This comment was imported from FlySpray: https://bugs.openttd.org/task/5284#comment11488

@DorpsGek
Copy link
Member Author

DorpsGek commented Sep 4, 2012

sbr wrote:

Another proposition to edit signs from the sign list window :
- Click the company icon to edit the sign;
- Click the sign name center the main viewport on the sign position;

Please find attached these two patches against r24510.

Attachments


This comment was imported from FlySpray: https://bugs.openttd.org/task/5284#comment11494

@DorpsGek
Copy link
Member Author

DorpsGek commented Sep 2, 2017

andythenorth wrote:

Patch 00 fails to apply on r27908, .rej attached

openttd-trunk(master)$ curl https://bugs.openttd.org/task/5284/getfile/8548/sign-list_00ctrl-click-open-extra-viewport_r24510.patch | patch -p1
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 2194 100 2194 0 0 14279 0 --:--:-- --:--:-- --:--:-- 14339
patching file src/lang/english.txt
Hunk # 1 FAILED at 2749.
1 out of 1 hunk FAILED -- saving rejects to file src/lang/english.txt.rej
patching file src/signs_gui.cpp
Hunk # 2 succeeded at 238 with fuzz 1 (offset -15 lines).
Hunk # 3 succeeded at 374 (offset -25 lines).

Attachments


This comment was imported from FlySpray: https://bugs.openttd.org/task/5284#comment14720

@DorpsGek DorpsGek added component: interface This is an interface issue flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) enhancement labels Apr 7, 2018
@andythenorth
Copy link
Contributor

No change for > 5 years. Prioritising to get some clarity, so let's pass on this one, thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: interface This is an interface issue flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)
Projects
None yet
Development

No branches or pull requests

2 participants