Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OTTD reports wrong value (19h) for CB 11 #5262

Closed
DorpsGek opened this issue Aug 2, 2012 · 3 comments
Closed

OTTD reports wrong value (19h) for CB 11 #5262

DorpsGek opened this issue Aug 2, 2012 · 3 comments
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)

Comments

@DorpsGek
Copy link
Member

DorpsGek commented Aug 2, 2012

George opened the ticket and wrote:

http://www.tt-forums.net/viewtopic.php?f=26&t=41357&p=1037560# p1037560

TTDpatch supported making RVs longer (up to twice as long = 16/8).
In case OTTD does not support it, it should at least ignore these values, but not report them as incorrect.

Reported version: 1.2.1
Operating system: All

This issue was imported from FlySpray: https://bugs.openttd.org/task/5262
@DorpsGek
Copy link
Member Author

DorpsGek commented Aug 8, 2012

Yexo wrote:

The documentation refers to road vehicles property 23, which refers to train property 21, which says: "This property reduces the length of train vehicles, in units of 1/8th (12.5%). The value 00 means the vehicle has the full length, 01 means shorter by 1/8th (12.5%), up to 05=shorter by 5/8ths (62.5%).". Extrapolating from that the value 19h would imply a length reduction of 312.5%. I'd say that is clearly incorrect and can be reported as such.
I understand that TTDPatch did make these values signed instead of unsigned in some way, however I don't think the current OpenTTD engine will be able to support it nor does it seem to be documented anywhere.

This comment was imported from FlySpray: https://bugs.openttd.org/task/5262#comment11432

@DorpsGek
Copy link
Member Author

George wrote:

I did not request supporting it. I just requested not to report errors (because that behaviour was correct for TTDp)

This comment was imported from FlySpray: https://bugs.openttd.org/task/5262#comment11467

@DorpsGek
Copy link
Member Author

frosch closed the ticket.

Reason for closing: Fixed

in r24713

This comment was imported from FlySpray: https://bugs.openttd.org/task/5262

@DorpsGek DorpsGek added flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) Vehicles labels Apr 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@DorpsGek