OpenTTD

Tasklist

FS#525 - News economy items show new/closing industries as full when economy set to summary and/or none

Attached to Project: OpenTTD
Opened by Kenn Booth (Smoovious) - Sunday, 07 January 2007, 18:12 GMT
Last edited by Patric Stout (TrueBrain) - Friday, 09 March 2007, 12:19 GMT
Type Feature Request
Category Interface
Status Closed
Assigned To Patric Stout (TrueBrain)
Operating System All
Severity Very Low
Priority Low
Reported Version trunk
Due in Version 0.5.1
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

With so many industries in large maps, even with them created with the low option in the mapgen, there are still way too many production-change messages, especially with smooth economy.

Personally, I don't care about those production change messages and only care about new/closing industry messages, but they're all lumped in together in the same setting.

I'd like to have a setting to keep showing new/closing industries as a full news item, even if economy news is set to summary or even off (preferably off).

-- Smoovious
This task depends upon

Closed by  Patric Stout (TrueBrain)
Saturday, 10 March 2007, 12:10 GMT
Reason for closing:  Implemented
Additional comments about closing:  This request is added in r9097
Comment by Kenn Booth (Smoovious) - Thursday, 08 March 2007, 23:35 GMT
Ok... it works for me, give it a try, see if you find anything I might have missed, or other _CONSTRUCTIVE_ criticism... :)

-- Smoovious
Comment by Patric Stout (TrueBrain) - Friday, 09 March 2007, 00:09 GMT
In fact, I personally think this is the wrong approach. Why not just add a new news-type which controls this, instead of a patch option? It sounds rather silly.
Comment by Kenn Booth (Smoovious) - Friday, 09 March 2007, 00:17 GMT
Minor formatting change
Comment by Kenn Booth (Smoovious) - Friday, 09 March 2007, 00:19 GMT
well, I had originally thought the same thing, which sparked cries of TTDX didn't have it, etc... don't think it offers enough use to deserve its own news type tho. General seems to be the most appropriate place for them, not counting Economy...

It is no worse than the way some other patches are implemented tho...

-- Smoovious
Comment by Kenn Booth (Smoovious) - Friday, 09 March 2007, 03:20 GMT
New diff to resolve a conflict introduced in r9075 changes...
Comment by Kenn Booth (Smoovious) - Friday, 09 March 2007, 03:22 GMT
as well as replacing if...then with a trinary operation
Comment by Kenn Booth (Smoovious) - Friday, 09 March 2007, 03:48 GMT
Minor formatting change again
Comment by Patric Stout (TrueBrain) - Friday, 09 March 2007, 12:20 GMT
Most developers do not like this way, but like the way I suggested above more. Also, the news_gui.cpp needs a good rewrite as it avoids limits we no longer have. Therefor Belugas and I took up this report, and are creating the patches for it.

We do thank you for your patch, and hope you continue to work for OpenTTD.

Loading...