Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

News economy items show new/closing industries as full when economy set to summary and/or none #525

Closed
DorpsGek opened this issue Jan 7, 2007 · 9 comments
Labels
component: interface This is an interface issue flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)

Comments

@DorpsGek
Copy link
Member

DorpsGek commented Jan 7, 2007

Smoovious opened the ticket and wrote:

With so many industries in large maps, even with them created with the low option in the mapgen, there are still way too many production-change messages, especially with smooth economy.

Personally, I don't care about those production change messages and only care about new/closing industry messages, but they're all lumped in together in the same setting.

I'd like to have a setting to keep showing new/closing industries as a full news item, even if economy news is set to summary or even off (preferably off).

-- Smoovious

Reported version: trunk
Operating system: All


This issue was imported from FlySpray: https://bugs.openttd.org/task/525
@DorpsGek
Copy link
Member Author

DorpsGek commented Mar 9, 2007

Smoovious wrote:

Ok... it works for me, give it a try, see if you find anything I might have missed, or other CONSTRUCTIVE criticism... :)

-- Smoovious

Attachments


This comment was imported from FlySpray: https://bugs.openttd.org/task/525#comment1038

@DorpsGek
Copy link
Member Author

DorpsGek commented Mar 9, 2007

TrueBrain wrote:

In fact, I personally think this is the wrong approach. Why not just add a new news-type which controls this, instead of a patch option? It sounds rather silly.


This comment was imported from FlySpray: https://bugs.openttd.org/task/525#comment1039

@DorpsGek
Copy link
Member Author

DorpsGek commented Mar 9, 2007

Smoovious wrote:

Minor formatting change

Attachments


This comment was imported from FlySpray: https://bugs.openttd.org/task/525#comment1040

@DorpsGek
Copy link
Member Author

DorpsGek commented Mar 9, 2007

Smoovious wrote:

well, I had originally thought the same thing, which sparked cries of TTDX didn't have it, etc... don't think it offers enough use to deserve its own news type tho. General seems to be the most appropriate place for them, not counting Economy...

It is no worse than the way some other patches are implemented tho...

-- Smoovious


This comment was imported from FlySpray: https://bugs.openttd.org/task/525#comment1041

@DorpsGek
Copy link
Member Author

DorpsGek commented Mar 9, 2007

Smoovious wrote:

New diff to resolve a conflict introduced in r9075 changes...

Attachments


This comment was imported from FlySpray: https://bugs.openttd.org/task/525#comment1042

@DorpsGek
Copy link
Member Author

DorpsGek commented Mar 9, 2007

Smoovious wrote:

as well as replacing if...then with a trinary operation


This comment was imported from FlySpray: https://bugs.openttd.org/task/525#comment1043

@DorpsGek
Copy link
Member Author

DorpsGek commented Mar 9, 2007

Smoovious wrote:

Minor formatting change again

Attachments


This comment was imported from FlySpray: https://bugs.openttd.org/task/525#comment1045

@DorpsGek
Copy link
Member Author

DorpsGek commented Mar 9, 2007

TrueBrain wrote:

Most developers do not like this way, but like the way I suggested above more. Also, the news_gui.cpp needs a good rewrite as it avoids limits we no longer have. Therefor Belugas and I took up this report, and are creating the patches for it.

We do thank you for your patch, and hope you continue to work for OpenTTD.


This comment was imported from FlySpray: https://bugs.openttd.org/task/525#comment1049

@DorpsGek
Copy link
Member Author

TrueBrain closed the ticket.

Reason for closing: Implemented

This request is added in r9097


This comment was imported from FlySpray: https://bugs.openttd.org/task/525

@DorpsGek DorpsGek added component: interface This is an interface issue flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) enhancement labels Apr 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: interface This is an interface issue flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)
Projects
None yet
Development

No branches or pull requests

1 participant