LordAro wrote:

Update, split into more patches, and implement Zuu's bug report fixes

hg patch queue, for r24376

Attachments

• 01_generalise_ContentInfotype_check.diff (3.73 KiB)
• 02_generalise_textfile_windows_slightly.diff (2.01 KiB)
• 03_make_some_funcs_return_actual_values.diff (9.93 KiB)
• 04_implement_view_content_textfiles.diff (9.05 KiB)
• view_dlc_textfiles_whole_r24376.diff (24.34 KiB)

This comment was imported from FlySpray: https://bugs.openttd.org/task/5236#comment11330

Yexo wrote:

I just committed the first 2 patched. The 3rd patch still has some issues:
- HasBaseSet: The name implies it returns a boolean, which is previously did. If you change the return value to a string you should update the name accordingly.
- ScriptScanner::FindScript: documentation mentions "find a script", "@return A filename of a file of the content": this is not explicit enough. It finds the main script (main.nut), not a random filename. I think a better function name is something like GetMainScript (that already exists, but this function services the same purpose).

This comment was imported from FlySpray: https://bugs.openttd.org/task/5236#comment11437

LordAro wrote:

done, although i just found a seg fault situation, which i shall attempt to rectify before re-submitting the patch
(If you have an item of content selected for download, then download it while still selecting it, a seg fault occurs in ContentInfo::GetTextfile - i you want to take a look ;) )
(in patch # 04)

This comment was imported from FlySpray: https://bugs.openttd.org/task/5236#comment11441

LordAro wrote:

fixed!

now against r24477 (if that matters too much)

and with added bonus patch :)

Attachments

• 03_make_some_funcs_return_actual_values.diff (10.04 KiB)
• 04_implement_view_content_textfiles.diff (9.40 KiB)
• 05_also_look_for_COPYING_textfile.diff (0.58 KiB)
• view_dlc_textfiles_whole_r24477.diff (19.42 KiB)

This comment was imported from FlySpray: https://bugs.openttd.org/task/5236#comment11443

LordAro wrote:

fixed 04_* patch:

Attachments

• 04_implement_view_content_textfiles.diff (9.12 KiB)

This comment was imported from FlySpray: https://bugs.openttd.org/task/5236#comment11456

Yexo closed the ticket.

Reason for closing: Implemented

In r24487 / r24488

This comment was imported from FlySpray: https://bugs.openttd.org/task/5236