Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translatable base set names #5234

Closed
DorpsGek opened this issue Jul 5, 2012 · 11 comments
Closed

Translatable base set names #5234

DorpsGek opened this issue Jul 5, 2012 · 11 comments
Labels
component: interface This is an interface issue flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)

Comments

@DorpsGek
Copy link
Member

DorpsGek commented Jul 5, 2012

Moriarty opened the ticket and wrote:

Three text issues, all on the text screen in as best I can tell, all languages (including english):

Base Graphics Set:
"original_windows" should probably be "Original Windows"
"NoSound" - "No Sound"
"NoMusic" - "No Music"

r24375

Reported version: trunk
Operating system: All


This issue was imported from FlySpray: https://bugs.openttd.org/task/5234
@DorpsGek
Copy link
Member Author

DorpsGek commented Jul 6, 2012

LordAro wrote:

I think the No[Sound|Music] options do not have spaces, as the name cannot have spaces
(i could be wrong though :) )


This comment was imported from FlySpray: https://bugs.openttd.org/task/5234#comment11311

@DorpsGek
Copy link
Member Author

DorpsGek commented Jul 6, 2012

Alberth wrote:

These are indeed names of basesets, rather than 'nice descriptions'. Names have no spaces in them, just like OpenTTD is not written as "Open TTD".

In the latter two cases it is the actual project name afaik, so the name is really correct.
In the first case, you can argue the name should be OriginalWindows, but on the other hand, it was an external project, so a really different name may be better.

Anyway, I think it is not important enough to fix; the original graphics cannot be updated eg to 32bpp, so they will fade into oblivion eventually.


This comment was imported from FlySpray: https://bugs.openttd.org/task/5234#comment11319

@DorpsGek
Copy link
Member Author

DorpsGek commented Jul 7, 2012

Moriarty wrote:

While "NoSound" and "NoMusic" may be the names of the "projects", from a users perspective it is of no matter that there is a "project" behind the options because they don't look like the sort of things that are "project names". All they'll notice (as I did) is that its quite odd that they're missing spaces when almost every other text string in the game is correctly formatted with spaces etc.


This comment was imported from FlySpray: https://bugs.openttd.org/task/5234#comment11327

@DorpsGek
Copy link
Member Author

DorpsGek commented Jul 7, 2012

Alberth wrote:

But the setting is a selection of which set of data files are to be used for sounds/music. It is not a enable/disable sound toggle.
That the data files of the NoSound project are all silent, is just a happy co-incidence with its name.

Looking at it from the other way, suppose you have 2 sets of (non-silent) sounds. Are they both to be named "Sound" ?
I suspect you'd prefer the FOO set and the BAR set, so you know which one is chosen.

The "NoSound" is just like BAR above, the name of the set of sounds.

Note that the program does not know what sounds a set contains (or whether the sound is actually audible). All sets are equal.


This comment was imported from FlySpray: https://bugs.openttd.org/task/5234#comment11328

@DorpsGek
Copy link
Member Author

DorpsGek commented Jul 8, 2012

Rubidium wrote:

The names are, as said, the untranslatable names of the settings. The names cannot be changed without messing up configurations, so I rather not change them at all. After all, basically all BaNaNaS content is named quite inconsistently as well.


This comment was imported from FlySpray: https://bugs.openttd.org/task/5234#comment11335

@DorpsGek
Copy link
Member Author

Moriarty wrote:

It is not a enable/disable sound toggle.

Ok, that's where my problem comes in. To me as a user (and I guess other users too) it /is/ a sound/nosound toggle. I mean, one of them explicitly says "NoSound" after all. In every other application I've ever used that has basically meant what it says, no sound, and it has meant it in a "Here user, select this for no sound" kind of way. Functionally that's what OTTD does, however unfortunately it does it in a way that is only in English and then only in grammatically incorrect English.
Rather than translate the untranslateable, how about adding a permanent setting that points to that "project" which is hard-coded in. That "project" will always be there after all and this way you could have a nicely translateable string for users.


This comment was imported from FlySpray: https://bugs.openttd.org/task/5234#comment11357

@DorpsGek
Copy link
Member Author

Rubidium wrote:

We don't translate 'own' names of sets. Or should we call OpenGFX LibreGFA or something in some languages? In my opinion it is much better for communication to NOT rename these own names as things will get pretty difficult to explain pretty soon. Especially since these sets come from third parties. The description is translated and that should be more than enough for someone to understand what the set is about.

If you use it as toggle between having sound and not having sound, then that's what your interpretation. The NoSound and NoMusic are purely meant so there does not need to be special code to handle the case where there is no set. They won't ever be automatically selected, unless they are the only one.

The reason why it's NoSound and not No Sound is because passing -S No Sound will fail on the console. So all base sets have to be without a space in their name. Likewise they are written to the configuration file, so changing them OR making them translateable is asking for a massive amount of trouble when people move config files around.


This comment was imported from FlySpray: https://bugs.openttd.org/task/5234#comment11364

@DorpsGek
Copy link
Member Author

Alberth wrote:

Translatable strings have the problem that what's called NoSound at your system might be called GeenGeluid at mine. Such translated names are very complicated to explain to users how to set them through a text medium such as IRC of forum posts, as at their system it is listed differently.

Therefore, these settings are better left untranslated, so everybody has the same NoSound word, even though some may not understand what it means exactly.


This comment was imported from FlySpray: https://bugs.openttd.org/task/5234#comment11365

@DorpsGek
Copy link
Member Author

Moriarty wrote:

I'm not suggesting translating "OpenGFX", That's clearly a name, just as OpenTTD is a name. however NoSound while technically a name doesn't come across that way to the user - its what they'd expect a setting to be called.
I appreciate that a space in a console won't work, however, again don't most apps have a specific setting for "no sound" rather than requiring a special mod to be downloaded and parsed in the regular way? A Sound/No Sound setting is typically a fundamental part of a system.

Alberth - That reasoning seems a little specious to me. Following it to its logical conclusion how do you currently tell a user what resolution to use, or to click on "Company performance graphy" or any number of other things they may want help with? Those things are translated and work fine.


This comment was imported from FlySpray: https://bugs.openttd.org/task/5234#comment11383

@DorpsGek
Copy link
Member Author

planetmaker wrote:

BaseSet, names are translatable. But they have to be translated within the sound set itself. NoSound is also a soundset.

Besides that, I'd really like to keep the name NoSound for the reasons Alberth pointed out. But descriptions are well translatable - and if they aren't, please feel free to provide them.


This comment was imported from FlySpray: https://bugs.openttd.org/task/5234#comment11799

@DorpsGek
Copy link
Member Author

andythenorth closed the ticket.

Reason for closing: Won't implement

Flyspray clean up: more than 5 years old, and not obvious what should be done with this next, so closing. If this offends, discuss with andythenorth in irc. Thanks.


This comment was imported from FlySpray: https://bugs.openttd.org/task/5234

@DorpsGek DorpsGek added component: interface This is an interface issue flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) enhancement labels Apr 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: interface This is an interface issue flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)
Projects
None yet
Development

No branches or pull requests

1 participant