frosch wrote:

Please go to the NewGRF settings, select FIRS 0.7.5 and tell us the MD5sum which is shown in the right panel, resp. make a screenshot of the NewGRF GUI.

This comment was imported from FlySpray: https://bugs.openttd.org/task/5231#comment11305

Moriarty wrote:

I'm using the nightly r24377

I've print-screened the md5.

Attachments

• Clipboard01.png (61.49 KiB)

This comment was imported from FlySpray: https://bugs.openttd.org/task/5231#comment11326

frosch wrote:

So, apparently the file you get when downloading is corrupted, the md5sum does not match.
Can you please upload "FIRS_Industry_Replacement_Set-0.7.5.tar" from your content_download folder to there, so we can compare the files and check what's actually different.

This comment was imported from FlySpray: https://bugs.openttd.org/task/5231#comment11329

cirschk wrote:

Hi, sorry for only coming back to you guys now.

Attached is a screenshot as well as the tar file for the GRF. I've had the problem from version 1.2.1 up to the latest nightly version.

Attachments

• firs-md5-screenshot.jpg (253.55 KiB)
• FIRS_Industry_Replacement_Set-0.7.5.tar (1090.00 KiB)

This comment was imported from FlySpray: https://bugs.openttd.org/task/5231#comment11332

frosch wrote:

Do you by any chance have multiple files named like that? Maybe in the "newgrf" or "data" folder?

This comment was imported from FlySpray: https://bugs.openttd.org/task/5231#comment11333

cirschk wrote:

Nope, I checked, I only have this tar in this folder - Documents\OpenTTD\content_download\newgrf.

This comment was imported from FlySpray: https://bugs.openttd.org/task/5231#comment11348

Moriarty wrote:

Same as Arno, I only have the one in NewGRF. In the entire "content_download" directory there is only one file with the word "industry" in it.

Attachments

• FIRS_Industry_Replacement_Set-0.7.5.tar (1090.00 KiB)

This comment was imported from FlySpray: https://bugs.openttd.org/task/5231#comment11358

Alberth wrote:

It does not make any sense to me.

The FIRS files you added here are exactly the same as my copy, but my check-sum displayed in the newgrf window is 4f0505bb9ee5f1aa279953bb6a3e6a5b, ie different from the screenshot.

The only explanation we have so far is that some other file pretends to be a firs file, and that file is what OpenTTD sees. Since it is different than the official file, openttd thinks it needs an update, and updates the file in content_download. However, since that file is not actually used, the update has no effect, and openttd still thinks it needs an update.

This however contradicts with your report that you have no other FIRS files.

To proof our hypothesis to be false, perhaps a little experiment is in order.
Make the FIRS file that you have non-findable for OpenTTD. For example, rename the extension from ".tar" to ".foo".
If you now start OpenTTD, you should not have FIRS in the newgrf list any more (if this happens our hypothesis is false, and we are back at square one in solving it).

Obviously, to get the file back, rename back to ".tar" and restart OpenTTD :)

If openttd still reports FIRS to be available after the above removal, please try to find this grf file as well. The README.txt that comes with openttd explains where the program looks for files.
If you find it, please report in which directory you found it, and please send us a copy so we can examine the file more closely.

In addition, it is probably useful to make this file also non-findable for OpenTTD (that is, repeat the above procedure, until OpenTTD does not list FIRS as available any more).

This comment was imported from FlySpray: https://bugs.openttd.org/task/5231#comment11360

cirschk wrote:

I followed your instructions and I only found two files in two different folders.

I found this FIRS_Industry_Replacement_Set-0.7.5.tar file in this folder:
Documents\OpenTTD\content_download\newgrf

And an older one FIRS_Industry_Replacement_Set-0.6.4.tar in this folder:
Documents\OpenTTD\content_download\data (I never renamed the back to *.tar)

I renamed this file FIRS_Industry_Replacement_Set-0.7.5.tar to FIRS_Industry_Replacement_Set-0.7.5.foo and started the game. The GRF did not show up in the NewGRF Settings window. After that, I quit the game and renamed the file back to FIRS_Industry_Replacement_Set-0.7.5.tar, restarted the game, checked if the GRF was available in the NewGRF Settings Window - it was there, checked if there was an update; and yet again the same had an update.

So I went a little further, renamed FIRS_Industry_Replacement_Set-0.7.5.tar again to FIRS_Industry_Replacement_Set-0.7.5.foo, started the game, re-downloaded the file and again checked if there was an update, and sure enough there was.

I deleted all the FIRS_Industry_Replacement_Set-0.7.5.tar files, including the old one, re-downloaded the the firs GRF, same effect. As a last effort, I removed my complete OpenTTD folder from My Documents, started the game, downloaded the GRF again and it still sees that there's an update available.

I also tried extracting the tar file, run the game and check if there's any difference. The only difference I could find is the MD5, but the GRF still finds an available update. I attached a screenshot of the different MD5.

The only thing I haven't tried is to completely remove the game, re-install and see what happens after that. Seems like we're in the same boat now, cause this does not make sense to me either.

I hope this helps.

Attachments

• firs-md5-screenshot-1.jpg (284.71 KiB)

This comment was imported from FlySpray: https://bugs.openttd.org/task/5231#comment11361

Rubidium wrote:

If the firs GRF isn't in the home directory, then it must be somewhere else. Most likely in the installation directory of OpenTTD. Did you by any chance get OpenTTD from a third party, e.g. a torrent, a friend or some download site that isn't OpenTTD's official site?

This comment was imported from FlySpray: https://bugs.openttd.org/task/5231#comment11362

Alberth wrote:

Note that the real NewGRF file is called "firs.grf" (the .tar file adds other stuff like license and readme files), what happens if you look for such a file at your system? (or look for *.grf)

You may also want to look for *.tar files at your entire system. If all is right, you probably only have them in the content download directory (since very few Windows programs use the .tar file format).

This comment was imported from FlySpray: https://bugs.openttd.org/task/5231#comment11363

cirschk wrote:

The installation was an original TTD with the rest downloaded from OpenTTD. I've done a search in the Documents directory as well as the installation to make sure that I don't miss anything. was just in the directories mentioned above. I searched for both *.tar and *.grf.

This comment was imported from FlySpray: https://bugs.openttd.org/task/5231#comment11366

Rubidium wrote:

The tar does not necessarily need to have firs in its name. It might just contain a file with the same name as your GRF and then things will fail.

Sadly enough it's currently impossible to tell you what file to look for and/or which file is causing the problems.

This comment was imported from FlySpray: https://bugs.openttd.org/task/5231#comment11380

Moriarty wrote:

I have deleted my FIRS industry file many times now and every time I do it disappears from the NewGRF list. When the file is deleted it stops being selected whenever I click on the "check for updates" button.
Whenever I redownload the file from the online content page to re-test this bug, the NewGRF reappears and the cycle begins again.

Note:
I also have a clean 1.2.1 install and that does NOT have this bug. If I download FIRS it doesn't bug me with updates all the time.
My trunk install is rather old and has a somewhat crufty config file (but with all my settings in so I don't want to delete it). I've attached a password sanitized version of my config file.

This comment was imported from FlySpray: https://bugs.openttd.org/task/5231#comment11381

Moriarty wrote:

Attached

Attachments

• openttd.cfg (12.25 KiB)

This comment was imported from FlySpray: https://bugs.openttd.org/task/5231#comment11382

frosch wrote:

You are using an "rather old" nightly? Then, please update that!

This comment was imported from FlySpray: https://bugs.openttd.org/task/5231#comment11386

michi_cc closed the ticket.

Reason for closing: Fixed

In r24416.

This comment was imported from FlySpray: https://bugs.openttd.org/task/5231