michi_cc wrote:

Minor nitpick: "bool dead = game && game->IsDead();"

Coding style says explicit comparisons with NULL.

This comment was imported from FlySpray: https://bugs.openttd.org/task/5230#comment11304

Zuu wrote:

Ah, there is always something you forget about the coding style. :-)

This comment was imported from FlySpray: https://bugs.openttd.org/task/5230#comment11321

Zuu wrote:

The reported coding style issue have been fixed.

Attachments

• show_gs_state_in_button_24396_v2.patch (1.84 KiB)

This comment was imported from FlySpray: https://bugs.openttd.org/task/5230#comment11367

Alberth wrote:

Please write full English sentences in the line comments and doxygen lines.
In the second hunk you can rewrite the dirty flag setting to "dirty |= SetScriptButtonColour(*button, dead);".
In the last hunk, there is also a widget repaint function "Window::SetWidgetDirty(widget_index)" that may be useful.

This comment was imported from FlySpray: https://bugs.openttd.org/task/5230#comment11371

Zuu wrote:

With
dirty |= SetScriptButtonColour(*button, dead);

will it not skip calling SetScriptButtonColour if dirty is already true?

What I could do is
dirty = SetScriptButtonColour(*button, dead) || dirty;

That will always call SetScriptButtonColour even if dirty is true.

Regarding full English sentences, do you refer to that the @param lines should end with full stop?

This comment was imported from FlySpray: https://bugs.openttd.org/task/5230#comment11372

Alberth wrote:

No, only || and && have short-circuit evaluation. | and & will always evaluate both sides.

Yes, I'd like to have complete sentences in comment and doxygen comments, starting with an upper-case letter, and ending with a full stop.
It is just a wish from me though, the coding style does not say about them.

This comment was imported from FlySpray: https://bugs.openttd.org/task/5230#comment11373

Zuu wrote:

Uses
- dirty = SetScriptButtonColour(*button, dead) || dirty;
- more complete sentences
- SetWidgetDirty for script debug button

Attachments

• show_gs_state_in_button_24488_v3.patch (2.02 KiB)

This comment was imported from FlySpray: https://bugs.openttd.org/task/5230#comment11457

Zuu closed the ticket.

Reason for closing: Implemented

In r24489

This comment was imported from FlySpray: https://bugs.openttd.org/task/5230