sbr wrote:

Add word by word caret move capability to Textbuf when pressing Ctrl+Left/Right.

Please find attached a patch against r24510.

Attachments

• textbuf_ctrl-left-right-caret-moves_r24510.patch (4.74 KiB)

This comment was imported from FlySpray: https://bugs.openttd.org/task/5203#comment11493

Zuu wrote:

I've modified your patch so that it is now more clear that it unconditionally removes the first char no matter if it is a white space or not. In your patch it could unconditionally remove a non-white space by the white space code. This is only a matter of clarity. Your original code provided the same behaviour.

This is found in ctrl-arrow-v2-r24516.patch

Additionally I've implemented Ctrl+Backspace and Ctrl+Delete in a separate patch that applies after the patch above. (they are fairly independent but are made in a patch queue so that arrow keys are placed first and may conflict slightly if applied in the reverse order)

This is found in ctrl-backspace-delete-v2-r24516.patch

Attachments

• ctrl-arrow-v2-r24516.patch (4.82 KiB)
• ctrl-backspace-delete-v2-r24516.patch (3.87 KiB)

This comment was imported from FlySpray: https://bugs.openttd.org/task/5203#comment11503

Zuu wrote:

The patches have been improved after feedback on IRC. I've now split the code change apart from the added features:

Patches:
http://devs.openttd.org/~zuu/text-edit/

This comment was imported from FlySpray: https://bugs.openttd.org/task/5203#comment11504

sbr wrote:

('s/to/too' in re-open request)

When moving caret by word, the character is tested at the caret position. A first move is then needed to decide what to do with this character.
Also when moving left, start of word is detected when the caret is before the word. A right move replace it at the start of the word.

But when removing by word, the first next char shouldn't be removed without testing it:
{Ctrl+Del, caret pos = 0, ' WORD'} should give 'WORD', not ''
{Ctrl+Backspace, caret pos = 6 (end of string), 'WORD W'} should give 'WORD ', not ''

Please find attached a patch against r24521.

Attachments

• fix-ctrl-backspace-ctrl-delete-dont-remove-first-char-without-testing-it_r24521.patch (0.60 KiB)

This comment was imported from FlySpray: https://bugs.openttd.org/task/5203#comment11505

sbr wrote:

Ctrl+Del & Ctrl+Backspace can remove to many characters.

This comment was imported from FlySpray: https://bugs.openttd.org/task/5203#comment11514

Zuu closed the ticket.

Reason for closing: Fixed

In r24530

This comment was imported from FlySpray: https://bugs.openttd.org/task/5203