Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The ability to drag and drop to buy land.... #5156

Closed
DorpsGek opened this issue Apr 17, 2012 · 4 comments
Closed

The ability to drag and drop to buy land.... #5156

DorpsGek opened this issue Apr 17, 2012 · 4 comments
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) patch from FlySpray This issue is in fact a Patch, but imported from FlySrpay

Comments

@DorpsGek
Copy link
Member

luckyl opened the ticket and wrote:

The ability to buy land in this game is very limited, you can only buy one square at a time. It really doesn't seem so bad untill you need to prevent a town from expanding, or reserving a little something for yourself. This patch should clear a lot of this up. The first feature, is the capability of a user, or server admin to disable the users ability to buy land at all. This will make a server completely invulnerable to that stupid thing people do (aka buying land around your newly built station). No more abuse of this feature. the next feature, probably the coolest, is the ability to buy land in chunks by dragging and dropping. The limit (or none at all) can be changed from within the advanced settings. No limit is simply achieved by disabling "enable restrictive land buying." If the option is set however the limit will be determined by the next setting. The great thing, is the default for these settings will result in the land buying process we're used to today, one square at a time.

I am aware of the other patches designed for exactly this purpose. However, I assume each one will eventually become obsolete. I think we need to add this, so no one will need to reinvent this patch once over again.

Once again, the typical user will see no difference...
-Luke

Attachments

Reported version: trunk
Operating system: All


This issue was imported from FlySpray: https://bugs.openttd.org/task/5156
@DorpsGek
Copy link
Member Author

luckyl wrote:

forgot to mention os tested on and revision number....
I am programming and testing the game on Ubuntu Linux 11.10 64bit
As specified by the patch title, the patch submitted was for r24122... But note, when new revisions come out, I will make sure they are compatible with my patch (and update it, if nessecary)


This comment was imported from FlySpray: https://bugs.openttd.org/task/5156#comment11093

@DorpsGek
Copy link
Member Author

planetmaker wrote:

IMHO it does not need three settings for this purpose; a single setting which defines the amount of concurrently allowed tiles to be bought is sufficient, always allowing drag+drop. And a 2nd setting which allows the amount of tiles to be bought within a certain amount of ticks, similarily to how terraforming and bulldozing is limited. We have enough settings anyway.

virtual void OnHundredthTick() should not be needed. But changing the setting should invalidate the window types which make use of this setting.


This comment was imported from FlySpray: https://bugs.openttd.org/task/5156#comment11094

@DorpsGek
Copy link
Member Author

luckyl wrote:

I think that having three options is perfectly acceptable, and straightforward. However I will work on one using your suggestions... And get back to you


This comment was imported from FlySpray: https://bugs.openttd.org/task/5156#comment11099

@DorpsGek
Copy link
Member Author

andythenorth closed the ticket.

Reason for closing: Won't implement

Mass closure of patch tickets with no commentary for >5 years. Goal is to reduce patch queue as an experiment to see if it aids faster reviewing and rejection/acceptance (it may not). If this offends you and the patch is maintained and compiles with current trunk, discuss with andythenorth in irc. (andythenorth has no ability to review patches but can re-open tickets).


This comment was imported from FlySpray: https://bugs.openttd.org/task/5156

@DorpsGek DorpsGek added Core flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) patch from FlySpray This issue is in fact a Patch, but imported from FlySrpay labels Apr 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) patch from FlySpray This issue is in fact a Patch, but imported from FlySrpay
Projects
None yet
Development

No branches or pull requests

1 participant