Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vehicles have a 150% maintenance rate #5137

Closed
DorpsGek opened this issue Apr 4, 2012 · 6 comments
Closed

Vehicles have a 150% maintenance rate #5137

DorpsGek opened this issue Apr 4, 2012 · 6 comments
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)

Comments

@DorpsGek
Copy link
Member

DorpsGek commented Apr 4, 2012

gramm opened the ticket and wrote:

It is possible for the vehicles to (accidentally) have a 150% maintenance rate. In which case they seem to never go to maintenance unless scheduled.

To recreate:

  1. Start a new game, look at the Advanced Settings, make sure "Maintenance intervals are in percents" is OFF and "default maintenance interval for road vehicles" is 150 days.
  2. Create a road vehicle depot.
  3. Buy one truck.
  4. Change "Maintenance intervals are in percents" from NO to YES
  5. The truck now has a maintenance interval of 150%.

Needless to say, this also happens with trains and other vehicles. Basically, what happens is, if a vehicle is stopped in a depot while the Advanced Setting ""Maintenance intervals are in percents" is switch, then the maintenance interval changes from Days to Percent without being converted. So, 150 days become 150% and a value of let's say 10% will become 10 days.

Reported version: 1.1.5
Operating system: All


This issue was imported from FlySpray: https://bugs.openttd.org/task/5137
@DorpsGek
Copy link
Member Author

DorpsGek commented Apr 5, 2012

planetmaker wrote:

What behaviour exactly do you expect and how could or should the values be converted?


This comment was imported from FlySpray: https://bugs.openttd.org/task/5137#comment11064

@DorpsGek
Copy link
Member Author

DorpsGek commented Apr 5, 2012

gramm wrote:

It is not possible to manually set a vehicle to a maintenance rate superior to 90%. Therefore, when switching from days to percent the maintenance rate should be limited to 90% maximum.

The best solution I see would be to convert between percents and days by calculating the vehicle reliability loss in the "maintenance in days" interval and setting this value as "maintenance interval in percent". So, let's say my train lose 1% of its maximum reliability in 10 days, then a maintenance interval of 70 days would become a interval of 7%. I am not sure, however, that this is how the game mechanics work and how difficult it is to implement.

The 90% limit seems to be a good enough solution. As thing are currently, switching between days and percent mid-game has disastrous consequences - especially because you can't change multiple vehicles' maintenance rate in one click.


This comment was imported from FlySpray: https://bugs.openttd.org/task/5137#comment11065

@DorpsGek
Copy link
Member Author

DorpsGek commented Apr 8, 2012

xiong wrote:

I agree with OP. 150% is absurd. gramm is correct to say a conversion of some sort might be made from days to percent. I don't think 90% is a good idea, though; breakdowns are near-continuous at some reliability level < 10%. servint_ispercent = true implies servicing demanded when such a percent has been lost from max reliability, just as servint_ispercent = false (intervals in days) imply such a number of days have gone since last service. Counter-intuitive but completely logical.

There are settings for "default" maintenance intervals:

servint_trains
servint_roadveh
servint_ships
servint_aircraft

I can't personally think of any reason to set the interval for a particular vehicle differently from the rest of its class; any change to these settings should simply propagate to all vehicles immediately. (They don't, of course; they apply only to new vehicles.)

Some would disagree, of course. I suggest a simple "reset" button that sets all vehicles to match the so-called "default" settings, however they have been set. No manual approach is feasible for a couple hundred vehicles; nor have I been able to discover how to do it in Console.


This comment was imported from FlySpray: https://bugs.openttd.org/task/5137#comment11067

@DorpsGek
Copy link
Member Author

Yexo wrote:

See also http://devs.openttd.org/~yexo/servicing.txt


This comment was imported from FlySpray: https://bugs.openttd.org/task/5137#comment11220

@DorpsGek
Copy link
Member Author

peter1138 wrote:

3 patches to implement per-vehicle settings for default/custom service intervals and days/percentage per vehicle:

http://git.fuzzle.org/openttd.git/log/?h=servint


This comment was imported from FlySpray: https://bugs.openttd.org/task/5137#comment11912

@DorpsGek
Copy link
Member Author

Rubidium closed the ticket.

Reason for closing: Fixed

In r24998


This comment was imported from FlySpray: https://bugs.openttd.org/task/5137

@DorpsGek DorpsGek added flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) Vehicles labels Apr 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)
Projects
None yet
Development

No branches or pull requests

1 participant