Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ship/river problem case for YAPF and NPF (when coming out of wrong end of depot) #5127

Closed
DorpsGek opened this issue Mar 27, 2012 · 4 comments
Closed

ship/river problem case for YAPF and NPF (when coming out of wrong end of depot) #5127

DorpsGek opened this issue Mar 27, 2012 · 4 comments
Labels
component: pathfinder This issue is related to Pathfinder flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)

Comments

@DorpsGek
Copy link
Member

odalman opened the ticket and wrote:

Attached is a ship route that works OK with standard pathfinder, has a problem with YAPF and a serious problem with NPF.

The ship is supposed to go to an iron ore mine, wait for full load, go through the depot to get service, go to a steel mill (deliver iron ore), and finally go to the depot for service.

It seems like the ship always leaves the northwest end of the depot. This might be the root cause of the problem, but the pathfinders have variying problems to deal with it.

The standard pathfinder quickly turns the ship around to go in the correct direction. This is the best. The ship graphic is always drawn parrallel to the river.

The YAPF seems to make a little side turn before reversing the ship. During that brief moment, the ship graphic is draw non-parallel to the river and an annoying message is shown, saying that the ship is lost. The message is quickly removed as soon as the ship is properly reversed.

The NPF is totally lost. The ship continues in the wrong direction to the far end of the river. Only then it is reversed.

In this particular situation, the alternative pathfinders are worse than the standard pathfinder. They should be fixed to not be worse. Especially the YAPF, which is marked as recommended in the settings. (Changing the setting about 90 degree turns do not seem to help.)

Reported version: 1.2.0-RC3
Operating system: Linux

This issue was imported from FlySpray: https://bugs.openttd.org/task/5127
@DorpsGek
Copy link
Member Author

frosch wrote:

Please try again to attach a savegame.

This comment was imported from FlySpray: https://bugs.openttd.org/task/5127#comment11037

@DorpsGek
Copy link
Member Author

odalman wrote:

trying

Attachments

This comment was imported from FlySpray: https://bugs.openttd.org/task/5127#comment11038

@DorpsGek
Copy link
Member Author

DorpsGek commented Jul 7, 2012

frosch wrote:

The ship only being able to leave the depot towards north seems to be a bug.

The "vehicle is lost" is correct though. Ships are not able to reverse on rivers esp. when "Forbid trains and ships from making 90° turns" is enabled (which is the case for the savegame). So the ship just continues straight until it hits a dead end and it is force-reversed.

This comment was imported from FlySpray: https://bugs.openttd.org/task/5127#comment11331

@DorpsGek
Copy link
Member Author

frosch closed the ticket.

Reason for closing: Fixed

in r24481

This comment was imported from FlySpray: https://bugs.openttd.org/task/5127

@DorpsGek DorpsGek added component: pathfinder This issue is related to Pathfinder flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) bug labels Apr 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component: pathfinder This issue is related to Pathfinder flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@DorpsGek