Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assertion fail #5120

Closed
DorpsGek opened this issue Mar 22, 2012 · 4 comments
Closed

Assertion fail #5120

DorpsGek opened this issue Mar 22, 2012 · 4 comments
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)

Comments

@DorpsGek
Copy link
Member

mb opened the ticket and wrote:

no crash.dmp

Attachments

Reported version: 1.2.0-RC3
Operating system: All


This issue was imported from FlySpray: https://bugs.openttd.org/task/5120
@DorpsGek
Copy link
Member Author

frosch wrote:

Do you know which windows (with scrollbars) were opened during the crash?
I assume you were just about to open a new one.


This comment was imported from FlySpray: https://bugs.openttd.org/task/5120#comment11006

@DorpsGek
Copy link
Member Author

mb wrote:

"landscaping" and "object selection"

The crash happened when clicking the last entry ("quay w shed"). It was triggered by a corrupt MariCo newGRF (forgot to include a source file in make, so only the action0s for that entry were available ...)

regards
Michael

Attachments


This comment was imported from FlySpray: https://bugs.openttd.org/task/5120#comment11007

@DorpsGek
Copy link
Member Author

DorpsGek commented Apr 1, 2012

frosch wrote:

The assertion is triggered via
a) BuildObjectWindow: "matrix->SetCount(ObjectClass::GetCount(_selected_object_class));" and
b) BuildObjectWindow::OnClick(): "this->GetWidget(WID_BO_SELECT_MATRIX)->SetCount(ObjectClass::GetCount(_selected_object_class));"
when ObjectClass::GetCount() returns 0.

As such the fix for this is somewhat part of the fix for #4967.


This comment was imported from FlySpray: https://bugs.openttd.org/task/5120#comment11057

@DorpsGek
Copy link
Member Author

frosch closed the ticket.

Reason for closing: Fixed

in r24171


This comment was imported from FlySpray: https://bugs.openttd.org/task/5120

@DorpsGek DorpsGek added Core flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) labels Apr 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)
Projects
None yet
Development

No branches or pull requests

1 participant