Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Debugging option: visible dirty rectangles #5101

Closed
DorpsGek opened this issue Mar 13, 2012 · 3 comments
Closed

Debugging option: visible dirty rectangles #5101

DorpsGek opened this issue Mar 13, 2012 · 3 comments
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) patch from FlySpray This issue is in fact a Patch, but imported from FlySrpay

Comments

@DorpsGek
Copy link
Member

Rhamphoryncus opened the ticket and wrote:

While trying to trace down just why zooming out on openttdcoop maps is so slow I realized I needed a way to monitor how frequently the viewport gets redrawn. Sure enough it revealed a few issues.

I don't consider the patch to be perfect yet, but other than stylistic stuff the major issues are:
* Control. At the moment it turns on when bounding boxes are turned on. I'm considering having ctrl-b cycle through none/bounding boxes/dirty boxes/both, as well as a separate toggle on the menu.
* Safety. The effect is that of rapid, bright flashing of various colours, covering most of the screen. The potential to induce seizures should be considered very carefully. Best I've come up with is require a setting be explicitly enabled (not just a shortcut or menu option) and display a message if you attempt to enable it without the setting.

Attachments

Reported version: trunk
Operating system: All

This issue was imported from FlySpray: https://bugs.openttd.org/task/5101
@DorpsGek
Copy link
Member Author

Alberth wrote:

How about just draw a line around the edges?
Depending on how well that works, you could also add a cross (top-left to bottom-right, and top-right to bottom-left).

That should mostly solve the flashing problem, I think.

This comment was imported from FlySpray: https://bugs.openttd.org/task/5101#comment10984

@DorpsGek
Copy link
Member Author

Rhamphoryncus wrote:

The dirty area is not always expanded to the whole 8x64 dirty block, so I'd have to change it to be larger when this is enabled, masking the exact behaviour we're interested in. A box also wouldn't work when scrolling (I'd have to redraw the screen to clear the old boxes.)

This comment was imported from FlySpray: https://bugs.openttd.org/task/5101#comment10987

@DorpsGek
Copy link
Member Author

Rubidium closed the ticket.

Reason for closing: Implemented

In r24065. Thanks for the patch

This comment was imported from FlySpray: https://bugs.openttd.org/task/5101

@DorpsGek DorpsGek added Core flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) patch from FlySpray This issue is in fact a Patch, but imported from FlySrpay labels Apr 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) patch from FlySpray This issue is in fact a Patch, but imported from FlySrpay
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@DorpsGek