Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The "last joined" server stopped being selected when opening NetworkGameWindow #5098

Closed
DorpsGek opened this issue Mar 12, 2012 · 1 comment
Labels
component: interface This is an interface issue flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)

Comments

@DorpsGek
Copy link
Member

adf88 opened the ticket and wrote:

Symptom.
When opening NetworkGameWindow the "last joined" server is not selected any more.

Cause.
NetworkGameWindow constructor calls "UpdateNetworkGameWindow(true);" where "true" means to clear the selection. Then it selects the "last joined" server. After behaviour of InvalidateData is changed, second (scheduled) invalidation clears the selection again.

Possible solution

  1. Use "gui" scope invalidation (immediate) in UpdateNetworkGameWindow
  2. Process invalidation (NetworkGameWindow) only while in "gui" scope. Don't use selection-clearing UpdateNetworkGameWindow while in constructor.
  3. Remove selection-clearing variant of UpdateNetworkGameWindow. It looks like some artefact.

It may be some combination of above. Patch for # 3 attached.

Attachments

Reported version: trunk
Operating system: All


This issue was imported from FlySpray: https://bugs.openttd.org/task/5098
@DorpsGek
Copy link
Member Author

Rubidium closed the ticket.

Reason for closing: Fixed

In r24070. Thanks for the patch.


This comment was imported from FlySpray: https://bugs.openttd.org/task/5098

@DorpsGek DorpsGek added component: interface This is an interface issue flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) bug labels Apr 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: interface This is an interface issue flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)
Projects
None yet
Development

No branches or pull requests

1 participant