Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The last joined server may be not visible (but selectable) even for a few seconds #5097

Closed
DorpsGek opened this issue Mar 12, 2012 · 2 comments
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)

Comments

@DorpsGek
Copy link
Member

adf88 opened the ticket and wrote:

Symptoms.
When opening NetworkGameWindow for the first time the name of the "last joined" server may be empty even for a few seconds. It looks like there is no item at all on the list, but it's there, we can select it. Related problem is that the "last joined" server information is not being refreshed immediately.

Cause.
When adding a server to the list of network games, the name (NetworkGameInfo::server_name) is empty initially (so nothing is displayed in the GUI). It gets filled up with the address of the server when sending a query for game information (NetworkUDPQueryServer). The first query is not being send immediately. Adding an item through NetworkGameListAddItem doesn't send one. We must wait until NetworkGameListRequery occurs (until requery counter reaches REQUERY_EVERY_X_GAMELOOPS).

Possible solution.
Make NetworkUDPQueryServer happen right after opening NetworkGameWindow.

Possible implementation.
Call NetworkUDPQueryServer right after adding the "last joined" server, in the NetworkGameList constructor (patch attached).

Attachments

Reported version: trunk
Operating system: All


This issue was imported from FlySpray: https://bugs.openttd.org/task/5097
@DorpsGek
Copy link
Member Author

adf88 wrote:

Screenshot.

Attachments


This comment was imported from FlySpray: https://bugs.openttd.org/task/5097#comment10967

@DorpsGek
Copy link
Member Author

Rubidium closed the ticket.

Reason for closing: Fixed

In r24062


This comment was imported from FlySpray: https://bugs.openttd.org/task/5097

@DorpsGek DorpsGek added flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) Network labels Apr 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)
Projects
None yet
Development

No branches or pull requests

1 participant