Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GSOrder.[insert modifying function] is missing #5089

Closed
DorpsGek opened this issue Mar 3, 2012 · 3 comments
Closed

GSOrder.[insert modifying function] is missing #5089

DorpsGek opened this issue Mar 3, 2012 · 3 comments
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)

Comments

@DorpsGek
Copy link
Member

DorpsGek commented Mar 3, 2012

Zuu opened the ticket and wrote:

Can the Order functions that modify orders be white-listed for NoGo? Eg. GSOrder.UnshareOrder.

I'm making a utility GS that clones and sells vehicles for connections as the source industry is changing production. If you want to argue against this kind of usage of NoGo, I can point out that you can already clone and sell vehicles. So this modifying of orders isn't the first company modifying action to be opened up to NoGo.

The reason why I want to modify the orders is that GSVehicle.SendVehicleToDepot fails at all cases when clicking the send to depot button in the GUI. Thus a better way of selling vehicles is to unshare its orders, clear the orders and put there two depot orders, switch orders once and then remove the last depot order. Additionally it is useful to turn around road vehicles with speed == 0. After doing that you can just leave the vehicle and be sure that at some point it will end up in the depot (as long as there is a path to it). (this is the method that I use in CluelessPlus to sell vehicles)

Reported version: trunk
Operating system: All

This issue was imported from FlySpray: https://bugs.openttd.org/task/5089
@DorpsGek
Copy link
Member Author

DorpsGek commented Mar 4, 2012

Zuu wrote:

Patch to whitelist all remaining GSOrder methods for NoGo.

Attachments

This comment was imported from FlySpray: https://bugs.openttd.org/task/5089#comment10938

@DorpsGek
Copy link
Member Author

DorpsGek commented Mar 9, 2012

Yexo wrote:

This is not what NoGo was ever intended for. We've discussed and rejected this mainly because, as you already say, this is (only) useful for managing a company. NoGo scripts should be used for goals, awards (BuildVehcle) etc.

You've pointed out CloneVehicle, that addition is now seen as a mistake that will perhaps be removed in 1.3.

This comment was imported from FlySpray: https://bugs.openttd.org/task/5089#comment10947

@DorpsGek
Copy link
Member Author

DorpsGek commented Mar 9, 2012

Yexo closed the ticket.

Reason for closing: Won't implement

This comment was imported from FlySpray: https://bugs.openttd.org/task/5089

@DorpsGek DorpsGek closed this as completed Mar 9, 2012
@DorpsGek DorpsGek added flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) wontfix labels Apr 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@DorpsGek