TrueBrain wrote:

Can you reproduce the problem in 1.1.5? (which was one of the key points I asked you about :D)

This comment was imported from FlySpray: https://bugs.openttd.org/task/5068#comment10899

krinn wrote:

crash.log from 1.1.5

I've done more testing, looks like the custom valuator might crash it, will dig that more to confirm. Maybe not returning a correct value (should be integer no?), currently the return value could be null.

local RoadBridgeList=AIList();
RoadBridgeList.AddList(cBridge.BridgeList);
RoadBridgeList.Valuate(cBridge.GetMaxSpeed); <---

Attachments

• crash.log (2.58 KiB)

This comment was imported from FlySpray: https://bugs.openttd.org/task/5068#comment10901

krinn wrote:

finally found it : bad recursive calling, VM goes oom or something.
function cBridge::Load(bUID)
// Load a bridge object, and detect if we have an UID or a tile gave
{
print("cBridge::Load");
local cobj=cBridge();
if (AIMap.IsValidTile(bUID))
{
cobj.bridgeUID=cBridge.GetBridgeUID(bUID);
if (cobj.bridgeUID!=null) cobj.firstside=bUID;
bUID=cobj.bridgeUID;
}
else cobj.bridgeUID=bUID;
if (bUID in cBridge.bridgedatabase) { cobj=cBridge.GetBridgeObject(bUID); cBridge.CheckBridge(bUID); } <<--- cBridge.CheckBridge(bUID) call cBridge.Load
else cobj.Save(); // we will not save a null bridgeUID
return cobj;
}

function cBridge::CheckBridge(bUID)
// Check if the bridge need an update of its infos
{
local cobj=cBridge.Load(bUID);
local validstart=cBridge.IsValidTile(cobj.firstside);
local validend=cBridge.IsValidTile(cobj.otherside);
if (!validstart || !validend)
{
DInfo("Bridge infos aren't valid anymore, bridge has moved ?",2,"cBridge::CheckBridge");
cBridge.DeleteBridge(bUID);
cobj.Save(); // try to save it again, the Save function will seek who is valid and who's not
}
}

That should solve my AI crashing part :)
Still remain the VM/openttd way to handle such issue.

This comment was imported from FlySpray: https://bugs.openttd.org/task/5068#comment10902

Rubidium wrote:

So this problem seems to be (is?) caused by (infinite) recursion, right? Then we should figure out what level of recursion we want to terminate an AI. Likewise maybe also for the number of operations executed within a valuate call.

This comment was imported from FlySpray: https://bugs.openttd.org/task/5068#comment10904

Rubidium closed the ticket.

Reason for closing: Fixed

In r23962

This comment was imported from FlySpray: https://bugs.openttd.org/task/5068