Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for pdf and html readme files? #5017

Closed
DorpsGek opened this issue Jan 28, 2012 · 6 comments
Closed

Support for pdf and html readme files? #5017

DorpsGek opened this issue Jan 28, 2012 · 6 comments
Labels
component: NewGRF This issue is related to NewGRFs flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)

Comments

@DorpsGek
Copy link
Member

PaulC opened the ticket and wrote:

The in-game text viewer for readme files is a fine addition to OTTD, but is there any possibility of adding support for pdf or html files? Obviously this would require OTTD to open the file in an external application, but would this be any different to opening websites?

Reported version: trunk
Operating system: All


This issue was imported from FlySpray: https://bugs.openttd.org/task/5017
@DorpsGek
Copy link
Member Author

Rubidium wrote:

That's difficult as the files are within a .tar file. As such we can't simply run an external command to open them, unless we unpack them somewhere first but then you're going to create a mess of files that just duplicates. In my opinion too much work for too little benefit.


This comment was imported from FlySpray: https://bugs.openttd.org/task/5017#comment10819

@DorpsGek
Copy link
Member Author

PaulC wrote:

The files won't necessarily be inside a tar, that's only really if you install via bananas. If you get your grfs etc from elsewhere (e.g the forums) then that probably won't be the case, plus of course you can always unpack the tar manually.


This comment was imported from FlySpray: https://bugs.openttd.org/task/5017#comment11016

@DorpsGek
Copy link
Member Author

frosch wrote:

The readme viewer only works for stuff in tars. So, it is meant for stuff from bananas; which should also be the usecase for the majority of users.

Anyway, we already support oopening URLs on the web for NewGRFs and iirc also for AIs and GSs. We might want to add that for basesets as well.


This comment was imported from FlySpray: https://bugs.openttd.org/task/5017#comment11018

@DorpsGek
Copy link
Member Author

PaulC wrote:

Frosh: That's not correct. As I said on the forums just the other day, the readme viewer works perfectly fine with unpacked subfolders.


This comment was imported from FlySpray: https://bugs.openttd.org/task/5017#comment11020

@DorpsGek
Copy link
Member Author

PaulC wrote:

To expand on my last few comments, such a feature would primarily be of benefit to non-bananas, non-tar grfs. Some of the more popular examples would be the various Canadian/NA grfs which are not on bananas and come with pdf readmes, or Michael Blunck's grfs which are also not available on bananas and come with html readmes.


This comment was imported from FlySpray: https://bugs.openttd.org/task/5017#comment11035

@DorpsGek
Copy link
Member Author

andythenorth closed the ticket.

Reason for closing: Won't implement

This could be a neat feature (I provide html docs for my grfs). But 1. Bananas can't accept html or pdf in the package files, and is work to change 2. html and PDF can be provided online (project website, repo or forums). That does require an internet connection, but so many things do, I think it's ok.


This comment was imported from FlySpray: https://bugs.openttd.org/task/5017

@DorpsGek DorpsGek added flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) component: NewGRF This issue is related to NewGRFs enhancement labels Apr 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: NewGRF This issue is related to NewGRFs flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)
Projects
None yet
Development

No branches or pull requests

1 participant