Zuu wrote:

Clarification regarding
"The API for telling which GS version the game was previously saved with will not work as expected by the GS author"

I mean that GSController::Load(version, table) will be giver version X also after the user has used the hacky workaround. As A GS/AI author I expect to be able to check if version is equal to my current version ( => apply normal loading code ) or if it is less than current version ( => apply backward compatibility conversion code ). If a user fool OpenTTD to use my newer GS under the old version it will cause trouble here. OpenTTD will at each save+load of this savegame report version == X, while the user really runs version Y of the game script.

If all this is too confusing. Just ignore everything about the bad user workaround and fix the problem instead. ;-)

This comment was imported from FlySpray: https://bugs.openttd.org/task/4933#comment10646

Zuu wrote:

Actually, when reviewing the OpenTTD code to see if I could make a patch on this topic, I found out that the loading code of gamescripts follow the exact same logic as AIs in regard of which version to load.

So there is no problem that OpenTTD can't pick a newer GS to load a script. It does that already.

A different problem though is that MinVersionToLoad doesn't work as intended. Yes, first time it rejects loading but then because it can't find a working version it tries next time to use the last version. A solution could be that the step when OpenTTD scans for scripts/ais, it remembers not just the last version but also older versions.

Note also that the docs (http://nogo.openttd.org/api/trunk/classGSInfo.html# 44f99f7837e3fcbb863faebef07589b6) specify that the default behaviour when MinVersionToLoad should be that OpenTTD should not load the save game with a newer version of the script. Only if a script explicitly tells OpenTTD to do so, it should use a newer version of the script to load the save.

This comment was imported from FlySpray: https://bugs.openttd.org/task/4933#comment10777

Zuu wrote:

Relevant places to look:
game_scanner.cpp, line 72 (here it rejects loading if min_version_to_load condition is not met)
game_sl.cpp, line 76 (here it first tries to load using the version specified in the save and then using -1 (latest) when that fails)

This comment was imported from FlySpray: https://bugs.openttd.org/task/4933#comment10778

Zuu wrote:

Sorry, the code works fine. My problem was that OpenTTD didn't find my old version of Tutorial unless I first untared them first for some reason.

This task can be closed :-)

This comment was imported from FlySpray: https://bugs.openttd.org/task/4933#comment10779

Rubidium closed the ticket.

Reason for closing: Requested by user

This comment was imported from FlySpray: https://bugs.openttd.org/task/4933