Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Music packs don't install (or download?) on x64 version 1.2.0-beta1 #4930

Closed
DorpsGek opened this issue Jan 1, 2012 · 8 comments
Closed
Labels
component: interface This is an interface issue flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)

Comments

@DorpsGek
Copy link
Member

DorpsGek commented Jan 1, 2012

mariush opened the ticket and wrote:

Downloaded the game and unpacked it into a folder with no spaces in the name or weird characters (preemptive, in case anyone thinks this may be the case).
In the content window, selected the two music packs and chose to download, they seem to download but afterwards, they are not selectable from the Options menu and they're not physically present.
Downloading just the standard music pack doesn't work either.

Side note/Feedback:

Ran for the first time and told me there's no graphics pack and asked me if I want to download it and I agreed. Download window showed and the first image I see is full of AI scripts and Scenarios.
For a first time user this may be very confusing, wouldn't it make sense to have these in a special category called "Essentials" pinned at the top of the download window?

Also, after selecting the Graphics and the SFX pack, the graphics pack applies itself automatically as it's the only one, but the SFX pack has to be manually selected from options - wouldn't it make sense to auto switch to it if the option before was No sound? Add a FIRST_RUN flag of some sorts for sound and music?
Maybe user thinks the game didn't detect the sound card properly or the volume is low and doesn't think to check the options window.

Reported version: 1.2.0-beta1
Operating system: Windows


This issue was imported from FlySpray: https://bugs.openttd.org/task/4930
@DorpsGek
Copy link
Member Author

DorpsGek commented Jan 1, 2012

mariush wrote:

I've used Process Monitor from SysInternals Suite to log what the executable does - apparently the tar.gz is unpacked to .tar, scanned and then both the tar.gz and the tar are deleted

The log with the significant part is attached.

somewhat unrelated - not sure how I feel about using my documents on windows, personally I'd prefer the files to be saved in the game's folder.

Attachments


This comment was imported from FlySpray: https://bugs.openttd.org/task/4930#comment10645

@DorpsGek
Copy link
Member Author

DorpsGek commented Jan 2, 2012

Rubidium wrote:

After downloading the .tar.gz and decompressing it, it should be extracting the .tar. I'm not seeing any evidence in the log you've given. You probalby cropped that from the log.


This comment was imported from FlySpray: https://bugs.openttd.org/task/4930#comment10652

@DorpsGek
Copy link
Member Author

DorpsGek commented Jan 2, 2012

mariush wrote:

Please have a second look... the decompression process starts at 7:12:18.6333821:

"7:12:18.6333821 PM","openttd.exe","13340","CloseFile","[..]Scott_Joplin_Anthology-2.0.0.tar.gz","SUCCESS",""
"7:12:18.6335775 PM","openttd.exe","13340","CreateFile","[..]\Scott_Joplin_Anthology-2.0.0.tar","SUCCESS","Desired Access: Generic Write, Read Attributes, Disposition: OverwriteIf, Options: Synchronous IO Non-Alert, Non-Directory File, Attributes: N, ShareMode: Read, Write, AllocationSize: 0, OpenResult: Created"

The rest below is consistent with how the insides of that decompression function works (i checked, I think it's "static bool GunzipFile(const ContentInfo *ci)" in network/network_content.cpp )... the decompression function ends at :

"7:12:18.6405304 PM","openttd.exe","13340","CloseFile","[..]Scott_Joplin_Anthology-2.0.0.tar.gz","SUCCESS",""
"7:12:18.6406117 PM","openttd.exe","13340","CloseFile","[..]Scott_Joplin_Anthology-2.0.0.tar","SUCCESS",""

I didn't have enough time to browse through the online svn folder to see which code accesses the decompressing function so I can't point the exact function.

Thanks for the comment though.


This comment was imported from FlySpray: https://bugs.openttd.org/task/4930#comment10653

@DorpsGek
Copy link
Member Author

DorpsGek commented Jan 2, 2012

mariush wrote:

The tar file is deleted at the end, check the third line from the end:

"7:12:18.6432221 PM","openttd.exe","13340","SetDispositionInformationFile","C:\Users\mariush\Documents\OpenTTD\content_download\baseset\Scott_Joplin_Anthology-2.0.0.tar","SUCCESS","Delete: True"
"7:12:18.6432472 PM","openttd.exe","13340","CloseFile","C:\Users\mariush\Documents\OpenTTD\content_download\baseset\Scott_Joplin_Anthology-2.0.0.tar","SUCCESS",""
"7:12:18.6435780 PM","openttd.exe","13340","TCP Disconnect","localhost:62816 -> zaphod.kakaopor.hu:http","SUCCESS","Length: 0, seqnum: 0, connid: 0"


This comment was imported from FlySpray: https://bugs.openttd.org/task/4930#comment10654

@DorpsGek
Copy link
Member Author

DorpsGek commented Jan 2, 2012

Rubidium wrote:

The point isn't that the decompression fails, but that I'm not seeing any traces of the files in the tar being placed in a directory on your file system. For the music we need to even move the files out of the tar, otherwise we can't play them with the external applications that play the music. So first it decompresses the .tar.gz to .tar, then it extracts the .tar into files on the file system. The creation of those files and the removal of the .tar and .tar.gz are not in the csv you attached earlier.


This comment was imported from FlySpray: https://bugs.openttd.org/task/4930#comment10655

@DorpsGek
Copy link
Member Author

DorpsGek commented Jan 2, 2012

Rubidium closed the ticket.

Reason for closing: Fixed

In r23719; somehow the extraction of the tar didn't work anymore


This comment was imported from FlySpray: https://bugs.openttd.org/task/4930

@DorpsGek DorpsGek closed this as completed Jan 2, 2012
@DorpsGek
Copy link
Member Author

DorpsGek commented Jan 3, 2012

mariush wrote:

Attached is the full log for what the 64bit version does from the moment it starts until I close it. It's basically start, check online content, select Scott Joplin Anthology, Download, Close game.

The CSV can be opened directly with any text viewer.
The PML file from the zip is supposed to be opened within Process Monitor from SysInternals Suite and from then on you can filter and see just the events you're interested in, for example the file input/output.

Please keep in mind the title of the bug was made before I had some time to investigate the issue further.

From what I can determine now, the game downloads Scott_Joplin_Anthology-2.0.0.tar.gz, unpacks it, but from this point the tar contents is not actually extracted - I don't see anywhere in the log the contents of the tar being written to disk, no calls to CreateFile or CloseFile for example, but I see the tar being opened by ExtractTar function and then the tar file is deleted.

Yesterday, I've alternated between testing with the 32bit version and the 64bit version downloading both OpenMSX and the Scott music pack or separately and at some point, the OpenMSX did get extracted - I suspect the 32bit version worked but I'm not 100% sure.
I had no luck getting this Scott Joplin Anthology through the game but I did get it separately from a website and after manually extracting it inside the folder, it's detected inside the game.

Attachments


This comment was imported from FlySpray: https://bugs.openttd.org/task/4930#comment10664

@DorpsGek
Copy link
Member Author

DorpsGek commented Jan 3, 2012

mariush wrote:

I apologize for bringing it again, I only saw now the reason why the bug was closed. Thanks.


This comment was imported from FlySpray: https://bugs.openttd.org/task/4930#comment10665

@DorpsGek DorpsGek added component: interface This is an interface issue flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) bug labels Apr 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: interface This is an interface issue flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)
Projects
None yet
Development

No branches or pull requests

1 participant