Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Callback 1D fails when mixing v7 and v8 NewGRFs #4923

Closed
DorpsGek opened this issue Dec 30, 2011 · 1 comment
Closed

Callback 1D fails when mixing v7 and v8 NewGRFs #4923

DorpsGek opened this issue Dec 30, 2011 · 1 comment
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)

Comments

@DorpsGek
Copy link
Member

Yexo opened the ticket and wrote:

See report http://www.tt-forums.net/viewtopic.php?p=987751# p987751

train_cmd.cpp:985 reads

if (t->GetGRF()->grf_version < 8) {

It should probably check head->GetGRF(). On the other hand it does group = SpriteGroup::Resolve(GetVehicleSpriteGroup(engine, v, false), &object); in GetVehicleCallbackParent, I'm not sure if that's correct either, since the callback is supposed to run on the engine, not on the wagon.

Reported version: 1.2.0-beta1
Operating system: All


This issue was imported from FlySpray: https://bugs.openttd.org/task/4923
@DorpsGek
Copy link
Member Author

DorpsGek commented Jan 3, 2012

frosch closed the ticket.

Reason for closing: Fixed

in r23744


This comment was imported from FlySpray: https://bugs.openttd.org/task/4923

@DorpsGek DorpsGek closed this as completed Jan 3, 2012
@DorpsGek DorpsGek added Core flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) labels Apr 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)
Projects
None yet
Development

No branches or pull requests

1 participant