FS#4923 - Callback 1D fails when mixing v7 and v8 NewGRFs

Attached to Project: OpenTTD
Opened by Thijs Marinussen (Yexo) - Thursday, 29 December 2011, 23:17 GMT
Last edited by frosch (frosch) - Tuesday, 03 January 2012, 22:38 GMT
Type Bug
Category Core
Status Closed
Assigned To No-one
Operating System All
Severity Low
Priority Normal
Reported Version 1.2.0-beta1
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No


See report

train_cmd.cpp:985 reads

if (t->GetGRF()->grf_version < 8) {

It should probably check head->GetGRF(). On the other hand it does group = SpriteGroup::Resolve(GetVehicleSpriteGroup(engine, v, false), &object); in GetVehicleCallbackParent, I'm not sure if that's correct either, since the callback is supposed to run on the engine, not on the wagon.
This task depends upon

Closed by  frosch (frosch)
Tuesday, 03 January 2012, 22:38 GMT
Reason for closing:  Fixed
Additional comments about closing:  in r23744