Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unintended behaviour with ship depots and buoys #4921

Closed
DorpsGek opened this issue Dec 29, 2011 · 3 comments
Closed

Unintended behaviour with ship depots and buoys #4921

DorpsGek opened this issue Dec 29, 2011 · 3 comments
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)

Comments

@DorpsGek
Copy link
Member

Lukeno94 opened the ticket and wrote:

I have observed in an online game that taking over a bankrupt company and selling their depot results in what appears to be a 32 bit overflow error (4,294,967,292) water tiles being owned by myself. If I then re-place the depot, it erroneously states that I own 0 water tiles. Also, buoys no longer show up in the list as they should do. When the overflow is combined with the "BaseCosts Mod 3.2.1." NewGRF, a massive source of income is generated as a result of this overflow - I do not know if it would generate this income without the overflow. Canals, however, act as they should do. Furthermore, the Details tab in the player's profile always assumes that all water pieces are canal pieces, regardless of if they are actually ship depots, buoys or actual canals.

Attachments

Reported version: 1.2.0-beta1
Operating system: All


This issue was imported from FlySpray: https://bugs.openttd.org/task/4921
@DorpsGek
Copy link
Member Author

Lukeno94 wrote:

Interestingly, being disconnected from the server reset the issue - however, the buoys were still not counting as water tiles.


This comment was imported from FlySpray: https://bugs.openttd.org/task/4921#comment10627

@DorpsGek
Copy link
Member Author

michi_cc wrote:

Buoys aren't counted because they actually have no owner and can be used by any company, not just the company who built them.


This comment was imported from FlySpray: https://bugs.openttd.org/task/4921#comment10630

@DorpsGek
Copy link
Member Author

michi_cc closed the ticket.

Reason for closing: Fixed

In r23686.


This comment was imported from FlySpray: https://bugs.openttd.org/task/4921

@DorpsGek DorpsGek added Core flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) labels Apr 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)
Projects
None yet
Development

No branches or pull requests

1 participant