Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

crash when changing the AI while its AI Parameters window is open #4909

Closed
DorpsGek opened this issue Dec 24, 2011 · 3 comments
Closed

crash when changing the AI while its AI Parameters window is open #4909

DorpsGek opened this issue Dec 24, 2011 · 3 comments
Labels
component: interface This is an interface issue flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)

Comments

@DorpsGek
Copy link
Member

SmatZ opened the ticket and wrote:

r23668

Select AI/Game Configuration
Select an AI (not a Random AI), click Configure
In the AI/Game configuration window, click Select AI
Select "Random AI", click Accept
-> crash

Attachments

Reported version: trunk
Operating system: All

This issue was imported from FlySpray: https://bugs.openttd.org/task/4909
@DorpsGek
Copy link
Member Author

SmatZ wrote:

If you don't change the AI to "Random AI", but to a different AI, all you get is "invalid" data in the window (because the parameters are not available in the new AI).

There is a similiar problem, when you change the "Maximum no. competitors" value, you might begin modifying an "unavailable" AI. I wasn't able to cause a crash that way however.

The seemingly simplest solution would be to make the "AI Parameters" and "AI List" window modal, or close the other window when one of them is open.

This comment was imported from FlySpray: https://bugs.openttd.org/task/4909#comment10606

@DorpsGek
Copy link
Member Author

TrueBrain closed the ticket.

Reason for closing: Fixed

Fixed in r23677

This comment was imported from FlySpray: https://bugs.openttd.org/task/4909

@DorpsGek
Copy link
Member Author

TrueBrain wrote:

The problem about changing settings of an AI that is grey'd out because you changed the available AIs is not a real issue. It is purely a graphical thing to grey out "unavailable" AIs; codewise they are always available. At best it can be considered "bad GUI", but won't result in crashes or errors.

This comment was imported from FlySpray: https://bugs.openttd.org/task/4909#comment10617

@DorpsGek DorpsGek added component: interface This is an interface issue flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) bug labels Apr 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component: interface This is an interface issue flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@DorpsGek