Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug fix for original graphics #4892

Closed
DorpsGek opened this issue Dec 18, 2011 · 4 comments
Closed

Bug fix for original graphics #4892

DorpsGek opened this issue Dec 18, 2011 · 4 comments
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)

Comments

@DorpsGek
Copy link
Member

PaulC opened the ticket and wrote:

I've done some additional bug fixes for the original graphics: transparency for the steel mill (the 2x2 part) and a fix for some non-translated colours in several arctic buildings. May as well go straight into trunk rather than via Addi's grf. I've also tidied the code a little as there were some undesirable action 7's in there.

In addition I have removed the following lines:

// Clipped vehicle in the original German DOS graphics
-1 * 6 07 83 01 \7! 03 02
-1 * 5 0A 01 01 5D 0C
-1 sprites/fix_graphics.png 18 296 09 16 20 -14 -7

There are several problems with this:

* What is meant by "original German DOS graphics" (as opposed to the standard TTD DOS base set)?
* The action 7 suggests that this is a fix for toyland, but the graphic is for a normal climate vehicle
* The graphic is of a livestock truck but appears to be replacing a steel truck (sprite # 3165)
* I've checked the DOS base set but there is no apparent bug for either the livestock truck or the steel truck
* These lines are skipped by an earlier action 7 so they aren't actually doing anything anyway

If anyone knows what this fix is supposed to be for perhaps they can take a look?

Attachments

Reported version: trunk
Operating system: All

This issue was imported from FlySpray: https://bugs.openttd.org/task/4892
@DorpsGek
Copy link
Member Author

PaulC wrote:

I also wanted to query the following lines:

// Graphics metadata pixel higher than actual graphics
-1 * 6 12 01 00 01 AC E2
-1 sprites/fix_graphics.png 66 296 01 10 9 0 0

This appears to be defining a font glyph (unicode number falls in the Private Use Area) but it looks like this is a replacement for sprite # 142 in the base set, so perhaps should be coded as an action A instead? The sprite in the png also looks like it's using the wrong colours, perhaps as a result of the palette being converted from windows to DOS?

I've left this one alone as I'm not sure about it, but again perhaps someone else could take a look?

This comment was imported from FlySpray: https://bugs.openttd.org/task/4892#comment10579

@DorpsGek
Copy link
Member Author

michi_cc wrote:

"Original German DOS graphics" means a specific release of TTD for DOS that was mostly sold in Germany. For some reason it has a corruption in the toyland graphics.

As my TTD CD is exactly that release, I've check the sprite in question, and I have to say that the replacement sprite seems to be indeed wrong. I've attached a cropped image from the decoded GRF showing the problem.

Attachments

This comment was imported from FlySpray: https://bugs.openttd.org/task/4892#comment10582

@DorpsGek
Copy link
Member Author

PaulC wrote:

Gotcha. I've put the code back in and added the correct sprite to the png, so this bug fix should now work properly. :)

Attachments

This comment was imported from FlySpray: https://bugs.openttd.org/task/4892#comment10584

@DorpsGek
Copy link
Member Author

Rubidium closed the ticket.

Reason for closing: Fixed

In r23639. Thanks

This comment was imported from FlySpray: https://bugs.openttd.org/task/4892

@DorpsGek DorpsGek added Core flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) labels Apr 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@DorpsGek