Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

For 0.5.0-RC2: CMD_PAUSE should not give cost estimates (fixes pause_on_join) #486

Closed
DorpsGek opened this issue Dec 30, 2006 · 1 comment
Closed

For 0.5.0-RC2: CMD_PAUSE should not give cost estimates (fixes pause_on_join) #486

DorpsGek opened this issue Dec 30, 2006 · 1 comment
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) patch from FlySpray This issue is in fact a Patch, but imported from FlySrpay

Comments

@DorpsGek
Copy link
Member

pvz opened the ticket and wrote:

CMD_PAUSE should not give cost estimates. This might seem like a petty bug, but this can actually break pause_on_join, if a client joins while the user playing on an interactive server holds the shift key down, causing a £0 cost estimate to be shown and the pause not actually to be performed.

While I was at it, I also added an enum for the 0xFF that is &'ed with a command to strip it from flags.

This fix is low-impact and should safely be able to make it into 0.5.0-RC2.

Attachments

Reported version: trunk
Operating system: All

This issue was imported from FlySpray: https://bugs.openttd.org/task/486
@DorpsGek
Copy link
Member Author

Celestar closed the ticket.

Reason for closing: Implemented

This comment was imported from FlySpray: https://bugs.openttd.org/task/486

@DorpsGek DorpsGek added Core flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) patch from FlySpray This issue is in fact a Patch, but imported from FlySrpay labels Apr 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) patch from FlySpray This issue is in fact a Patch, but imported from FlySrpay
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@DorpsGek