Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Old savegames get current settings, not defaults #4859

Closed
DorpsGek opened this issue Dec 1, 2011 · 3 comments
Closed

Old savegames get current settings, not defaults #4859

DorpsGek opened this issue Dec 1, 2011 · 3 comments
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)

Comments

@DorpsGek
Copy link
Member

DorpsGek commented Dec 1, 2011

TrueBrain opened the ticket and wrote:

Loading old savegames causes some settings, which werent in the savegame for that version, to be set to the current active ones, instead of the default ones.

A patch that might fix it (totally untested!)

Attachments

Reported version: trunk
Operating system: All


This issue was imported from FlySpray: https://bugs.openttd.org/task/4859
@DorpsGek
Copy link
Member Author

DorpsGek commented Dec 1, 2011

frosch wrote:

I would assume this breaks at least conversion of TTDP non-stop handling.


This comment was imported from FlySpray: https://bugs.openttd.org/task/4859#comment10527

@DorpsGek
Copy link
Member Author

Rubidium wrote:

Most settings influence the gameplay significantly, so for those (e.g. pathfinder), it'd be better to take the customised ones. Others do influence the game play, such as the allowance of 90 degree turns; if that gets disabled the savegame is basically useless. Same holds for the dynamic engines settings; it changes the way competing NewGRFs are handled and would break vehicle IDs, trashing the whole game.

So I'd leave the current behaviour. Intervene when it really matters, and otherwise just use the current 'newgame' settings. That's much more friendly w.r.t. favourite pathfinder settings than just using 'our' defaults.


This comment was imported from FlySpray: https://bugs.openttd.org/task/4859#comment10600

@DorpsGek
Copy link
Member Author

Rubidium closed the ticket.

Reason for closing: Fixed

In r23693


This comment was imported from FlySpray: https://bugs.openttd.org/task/4859

@DorpsGek DorpsGek added Core flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) labels Apr 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)
Projects
None yet
Development

No branches or pull requests

1 participant