Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AIOrder not handling implicit orders correctly #4823

Closed
DorpsGek opened this issue Nov 7, 2011 · 3 comments
Closed

AIOrder not handling implicit orders correctly #4823

DorpsGek opened this issue Nov 7, 2011 · 3 comments
Labels
component: AI/Game script (squirrel) This issue is related to Squirrel (Scripting language) flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)

Comments

@DorpsGek
Copy link
Member

DorpsGek commented Nov 7, 2011

frosch opened the ticket and wrote:

Methods of AIOrder are said to ignore implicit orders and hide them from the AI.

While this works for ResolveOrder, it does not work for ResolveOrderPosition. (Note that ResolveOrder actually relies on the current behaviour of ResolveOrderPosition)
Furthermore most Set* methods do not use either of the two conversion functions.

So, basically all order modifying methods are broken.

Reported version: trunk
Operating system: All

This issue was imported from FlySpray: https://bugs.openttd.org/task/4823
@DorpsGek
Copy link
Member Author

DorpsGek commented Nov 8, 2011

Yexo wrote:

This should fix all cases.

Attachments

This comment was imported from FlySpray: https://bugs.openttd.org/task/4823#comment10483

@DorpsGek
Copy link
Member Author

DorpsGek commented Nov 8, 2011

Yexo wrote:

The assert in AIOrderPositionToRealOrderPosition was wrong.

Attachments

This comment was imported from FlySpray: https://bugs.openttd.org/task/4823#comment10485

@DorpsGek
Copy link
Member Author

DorpsGek commented Nov 8, 2011

Yexo closed the ticket.

Reason for closing: Fixed

In r23133

This comment was imported from FlySpray: https://bugs.openttd.org/task/4823

@DorpsGek DorpsGek closed this as completed Nov 8, 2011
@DorpsGek DorpsGek added flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) bug component: AI/Game script (squirrel) This issue is related to Squirrel (Scripting language) labels Apr 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component: AI/Game script (squirrel) This issue is related to Squirrel (Scripting language) flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@DorpsGek