OpenTTD

Tasklist

FS#4823 - AIOrder not handling implicit orders correctly

Attached to Project: OpenTTD
Opened by frosch (frosch) - Monday, 07 November 2011, 17:46 GMT
Last edited by Thijs Marinussen (Yexo) - Tuesday, 08 November 2011, 15:44 GMT
Type Bug
Category Script → NoAI
Status Closed
Assigned To No-one
Operating System All
Severity Medium
Priority Normal
Reported Version trunk
Due in Version 1.1.4
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

Methods of AIOrder are said to ignore implicit orders and hide them from the AI.

While this works for ResolveOrder, it does not work for ResolveOrderPosition. (Note that ResolveOrder actually relies on the current behaviour of ResolveOrderPosition)
Furthermore most Set* methods do not use either of the two conversion functions.

So, basically all order modifying methods are broken.
This task depends upon

Closed by  Thijs Marinussen (Yexo)
Tuesday, 08 November 2011, 15:44 GMT
Reason for closing:  Fixed
Additional comments about closing:  In r23133
Comment by Thijs Marinussen (Yexo) - Tuesday, 08 November 2011, 13:31 GMT
This should fix all cases.
Comment by Thijs Marinussen (Yexo) - Tuesday, 08 November 2011, 15:09 GMT
The assert in AIOrderPositionToRealOrderPosition was wrong.

Loading...