Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disallow selection from going beynd SE or SW border #4816

Closed
DorpsGek opened this issue Nov 6, 2011 · 3 comments
Closed

Disallow selection from going beynd SE or SW border #4816

DorpsGek opened this issue Nov 6, 2011 · 3 comments
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) patch from FlySpray This issue is in fact a Patch, but imported from FlySrpay

Comments

@DorpsGek
Copy link
Member

DorpsGek commented Nov 6, 2011

adf88 opened the ticket and wrote:

When selecting a fix-sized, rectangular area of tiles (e.g. placing a station), selection is allowed to be partially hidden beyond SE and/or SW border. The patch prevents selection from passing these borders.

Attachments

Reported version: trunk
Operating system: All


This issue was imported from FlySpray: https://bugs.openttd.org/task/4816
@DorpsGek
Copy link
Member Author

DorpsGek commented Nov 6, 2011

adf88 wrote:

Update (I found a bug).

Attachments


This comment was imported from FlySpray: https://bugs.openttd.org/task/4816#comment10478

@DorpsGek
Copy link
Member Author

DorpsGek commented Nov 8, 2011

Rubidium wrote:

Wouldn't it be better is OnPlaceObject is passed the selection's position instead of the mouse position? Or is there something I'm missing that will mess things up in other cases?


This comment was imported from FlySpray: https://bugs.openttd.org/task/4816#comment10489

@DorpsGek
Copy link
Member Author

andythenorth closed the ticket.

Reason for closing: Won't implement

Mass closure of patch tickets with no commentary for >5 years. Goal is to reduce patch queue as an experiment to see if it aids faster reviewing and rejection/acceptance (it may not). If this offends you and the patch is maintained and compiles with current trunk, discuss with andythenorth in irc. (andythenorth has no ability to review patches but can re-open tickets).


This comment was imported from FlySpray: https://bugs.openttd.org/task/4816

@DorpsGek DorpsGek added Core flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) patch from FlySpray This issue is in fact a Patch, but imported from FlySrpay labels Apr 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) patch from FlySpray This issue is in fact a Patch, but imported from FlySrpay
Projects
None yet
Development

No branches or pull requests

1 participant