Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Climate specific canal graphics for openttd.grf #4787

Closed
DorpsGek opened this issue Sep 24, 2011 · 4 comments
Closed

Climate specific canal graphics for openttd.grf #4787

DorpsGek opened this issue Sep 24, 2011 · 4 comments
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)

Comments

@DorpsGek
Copy link
Member

PaulC opened the ticket and wrote:

openttd.grf only contains canal sprites for temperate climate which look visibly out of place in other climates. This seems a little odd as George's original canal grf had sprites for arctic and tropic as well. I've already spoken to George and he was ok with me making a few minor adjustments, so I submit a revised set of sprites for canals and aqueducts, as well as the necessary nfo for inclusion in openttd.grf.

While I'm on the subject of canals and aqueducts, it seems that action 3 feature 5 does not support aqueducts (or if it does then it isn't documented). Would it be possible to implement this?

Attachments

Reported version: 1.1.3
Operating system: All


This issue was imported from FlySpray: https://bugs.openttd.org/task/4787
@DorpsGek
Copy link
Member Author

Rubidium wrote:

Why is the transparency removed from the aqueducts northern fence? Why is the green that would shine through from the background coloured yellow in the non-temperate aqueducts northern fence? Why not change the colour of what is the fence for the temperate ones?

Furthermore, the palette seems to be the Windows palette whereas OpenTTD uses the DOS palette. OpenTTD also uses PNGs for the source files, not PCX.

It would be really helpful if this could be coded/supplied as an addendum to the current canal graphics/aqueduct, instead of providing different graphics. Finally, a patch to the actual source code would be much easier for us as then we can see what is intentionally changed and what isn't. The source code can be found in the media/extra_grf directory.


This comment was imported from FlySpray: https://bugs.openttd.org/task/4787#comment10412

@DorpsGek
Copy link
Member Author

PaulC wrote:

The northern fence of the aqueduct isn't supposed to have any transparency - the green colour you see is the colour of the railings, so that's actually a bug in the current sprites. As for why the railings are coloured yellow in other climates, you'd have to ask George as that was part of his original design, but if you would prefer to keep the same style across all climates then that won't be a problem.

FWIW I tried the code and sprites in a modified version of openttd.grf, the only issue I noticed was that the menu sprite for locks didn't appear. I don't know why this is - I appear to have coded it correctly and it works as intended in TTDPatch, so perhaps this is an issue with OTTD?

I'm afraid I don't know how to write a patch or how to compile OTTD so I can't be much help to you there, certainly not in the short term. In the meantime I hope the attached png meets your requirements.

Attachments


This comment was imported from FlySpray: https://bugs.openttd.org/task/4787#comment10413

@DorpsGek
Copy link
Member Author

DorpsGek commented Oct 1, 2011

Rubidium wrote:

Regarding the menu sprite... OpenTTD doesn't "support" TTDPatch's way. It already had its own way.

In any case, the base set should use action5 canals for at least setting some basic canals (in this case I'd say the temperate canals). Then with action123 we can add canal graphics for other climates.

Regarding "compiling OpenTTD", you only need to make the GRF from the files in media/extra_grf from an OpenTTD checkout. Then the version control tool used for the checkout can be used to generate the patch.


This comment was imported from FlySpray: https://bugs.openttd.org/task/4787#comment10417

@DorpsGek
Copy link
Member Author

DorpsGek commented Oct 2, 2011

Rubidium closed the ticket.

Reason for closing: Implemented

In r22971


This comment was imported from FlySpray: https://bugs.openttd.org/task/4787

@DorpsGek DorpsGek closed this as completed Oct 2, 2011
@DorpsGek DorpsGek added Core flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) labels Apr 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)
Projects
None yet
Development

No branches or pull requests

1 participant