planetmaker wrote:

Very nice thing. During testing I found though, that the end of files is a bit truncated (random idea: maybe difference between line heights and actual scroll steps?)

Attachments

• eof.png (56.62 KiB)

This comment was imported from FlySpray: https://bugs.openttd.org/task/4780#comment10377

LordAro wrote:

hmm. i cannot reproduce this.
which version of firs?
i think the os would be good too.

come on, make a proper bug report ;P

This comment was imported from FlySpray: https://bugs.openttd.org/task/4780#comment10394

planetmaker wrote:

What shall I say? It shows the same for every readme (firs, I checked, not just that one. What more info do you need? I don't think it matters as the hardware and OS at this level is quite abstracted away; I tested on OSX 10.6.8 compiled as x86_64 with debugging enabled.

Do you use the default sprite fonts? Did you try both base sets?

This comment was imported from FlySpray: https://bugs.openttd.org/task/4780#comment10396

monoid wrote:

Cool idea.

I've gone through your patch, and added some comments. Look out for lines starting with "# # # ".

Attachments

• viewreadme-22941-comments.txt (17.06 KiB)

This comment was imported from FlySpray: https://bugs.openttd.org/task/4780#comment10398

LordAro wrote:

new patch!

most, but not all of monoid's suggestions have been implemented, including the deletion of TrimWhitespace() - too much trouble

also i would like to say that implementing your changes to vscroll->GetCapacityFromWidget() actually caused me to see planetmaker's bug :) i have hopefully fixed that though

Attachments

• viewreadme-r22941-2.diff (13.05 KiB)

This comment was imported from FlySpray: https://bugs.openttd.org/task/4780#comment10401

LordAro wrote:

i should probably mention that i have no idea what's wrong with the scrollbars, and if someone else wants a go, by all means post the result :)

i believe the problem to be something to do with the FillDrawPixelInfo() function in drawwidget()

This comment was imported from FlySpray: https://bugs.openttd.org/task/4780#comment10402

Alberth wrote:

It has indeed.

As monoid said: "The dimensions passed to DrawString are relative to the DrawPixelInfo you set in FillDrawPixelInfo above.."
(I should have realized this sooner, sorry).

As you set the top-left to (r.left, r.top), you don't need to add r.left and r.top to left and top any-more (also mentioned by monoid already). That also makes 'top' mostly useless, you can easily eliminate it.
I am quite puzzled why you set the padding-parameter of vscrollbar->getCapacityFromWidget() to this->line_height. I am guessing you were trying to compensate for r.top above, but it should be this->top_spacing + this->bottom_spacing (which you add in UpdateWidgetSize).

Possible further improvements:
- Alignment of text is not so good due to using a proportional font (at least at my screen).
- TAB replacement by space makes indenting and making nice columns pretty much impossible (partially also due to the proportional font).
- Handling of trailing whitespace at a line
- Handling of empty lines at the start and end of the text.
- Check for a readme file in the language of the user first.
- Support for UTF-8 (many non-english readmes have non-ascii characters).

This comment was imported from FlySpray: https://bugs.openttd.org/task/4780#comment10415

peter1138 closed the ticket.

Reason for closing: Implemented

In r23178

This comment was imported from FlySpray: https://bugs.openttd.org/task/4780