Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash when building object on coast tile. #4775

Closed
DorpsGek opened this issue Sep 15, 2011 · 7 comments
Closed

Crash when building object on coast tile. #4775

DorpsGek opened this issue Sep 15, 2011 · 7 comments
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)

Comments

@DorpsGek
Copy link
Member

mb opened the ticket and wrote:

Crash when building object on coast tile.

No crash.sav nor crash.dmp available.

Attachments

Reported version: 1.1.3-RC1
Operating system: All


This issue was imported from FlySpray: https://bugs.openttd.org/task/4775
@DorpsGek
Copy link
Member Author

Yexo wrote:

I can't get it to crash with MariCo v0.2 15.12.2010. What do you need to do exactly to get it to crash?


This comment was imported from FlySpray: https://bugs.openttd.org/task/4775#comment10365

@DorpsGek
Copy link
Member Author

mb wrote:

I can't get it to crash with MariCo v0.2 15.12.2010.

Well, it´s not with MariCo 0.2, but with 0.23 (under development).


This comment was imported from FlySpray: https://bugs.openttd.org/task/4775#comment10372

@DorpsGek
Copy link
Member Author

Yexo wrote:

Can you upload a minimal example so we can reproduce the crash? In case you don't want to make it public yet you can just email it.


This comment was imported from FlySpray: https://bugs.openttd.org/task/4775#comment10375

@DorpsGek
Copy link
Member Author

DorpsGek commented Oct 4, 2011

mb wrote:

I have removed lots of code, yet it´s still not a "minimal example". Try to build "quays" on coast tiles.

Attachments


This comment was imported from FlySpray: https://bugs.openttd.org/task/4775#comment10428

@DorpsGek
Copy link
Member Author

DorpsGek commented Oct 4, 2011

Yexo wrote:

Thanks for that.

The crash is an assert in DoCommandPInternal, the result from the test and exec run are different. The test run succeeds while the exec run fails due to the tile check callback returning 1 (it returns 0 during the test run).

I can reproduce this by reading and modifying an uninitialized temporary storage value.


This comment was imported from FlySpray: https://bugs.openttd.org/task/4775#comment10429

@DorpsGek
Copy link
Member Author

DorpsGek commented Oct 4, 2011

Yexo wrote:

The problem is that the newgrf is checking some values from var 62. In testmode these have different values than in exec mode because in exec mode the tile is cleared before the callback is called.


This comment was imported from FlySpray: https://bugs.openttd.org/task/4775#comment10430

@DorpsGek
Copy link
Member Author

DorpsGek commented Oct 4, 2011

Yexo closed the ticket.

Reason for closing: Fixed

In r22994


This comment was imported from FlySpray: https://bugs.openttd.org/task/4775

@DorpsGek DorpsGek closed this as completed Oct 4, 2011
@DorpsGek DorpsGek added Core flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) labels Apr 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)
Projects
None yet
Development

No branches or pull requests

1 participant