duizendnegen wrote:

Removed the bool show_stop_ai in AIDebugWindow
Fixed reverted patch

Attachments

• stop_ai_2-v22854.patch (8.28 KiB)

This comment was imported from FlySpray: https://bugs.openttd.org/task/4768#comment10350

duizendnegen wrote:

Increased save version
Replaced tabs with spaces

Attachments

• stop_ai_3-v22854.patch (8.79 KiB)

This comment was imported from FlySpray: https://bugs.openttd.org/task/4768#comment10352

Zuu wrote:

I've skimmed through your code and have these comments:
- The function isAIStopable have to be renamed as IsAIStopable to confirm with the coding standards.
- I don't see why you have a cheat that enable/disable using of a debug action. If you want to have it as a sheet, I would think the stop AI action should be available in the cheat dialog (eg. a popup window that asks the user to pick a company). In the debug window it doesn't make sense to involve cheating.
- I think your patch don't disallow using the "stopai" console command even if your cheat is not enabled.

This comment was imported from FlySpray: https://bugs.openttd.org/task/4768#comment10457

Zuu wrote:

However, if one thinks that stopping AIs should require a cheat, then I would suggest that if the gui.ai_developer_tools setting is enabled, no cheating should be required. Then make it consistent so that a user needs to either use cheats or the ai developer setting to gain access to stopping AIs through both GUI and the console.

I would also be fine if you auto-cheat for me if I have the AI developer setting active in order to block that users use that setting to bypass the cheat mark. As long as it doesn't get in the way of AI debugging.

This comment was imported from FlySpray: https://bugs.openttd.org/task/4768#comment10458

Rubidium wrote:

In what was is the console command not sufficient? If it is for AI debugging, then reloading would probably be the thing you'd always be wanting to do, right?

This comment was imported from FlySpray: https://bugs.openttd.org/task/4768#comment10488

Rubidium closed the ticket.

Reason for closing: Won't implement

This comment was imported from FlySpray: https://bugs.openttd.org/task/4768