Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TT savegame: "go non-stop to" translated as "go non-stop via" #4716

Closed
DorpsGek opened this issue Aug 8, 2011 · 3 comments
Closed

TT savegame: "go non-stop to" translated as "go non-stop via" #4716

DorpsGek opened this issue Aug 8, 2011 · 3 comments
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)

Comments

@DorpsGek
Copy link
Member

DorpsGek commented Aug 8, 2011

Jubilee opened the ticket and wrote:

A bug i reported in the forum (http://www.tt-forums.net/viewtopic.php?f=31&t=54580) and a workaround provided in the next post by Eddi, but it's still a bug so i'm reporting it here.

If the "new orders are 'non-stop' by default" setting is turned to ON and the attached savegame is loaded (an old TT savegame - not TTD), all "go non-stop to" orders already existing in the game are translated as "go non-stop via". On has to turn the "new orders are 'non-stop' by default" OFF before loading the game in order for train orders to be translated correctly.

Reported version: 1.1.2-RC2
Operating system: All

This issue was imported from FlySpray: https://bugs.openttd.org/task/4716
@DorpsGek
Copy link
Member Author

frosch wrote:

This is meant for loading TTDPatch savegames.

TTDPatch cannot have both "non-stop and "go-via" in a game, but has a setting to choose at startup.
I do not know whether TTDPatch stores the setting in savegames (i suspect not), but at least OpenTTD does not read it.

To still allow loading some TTDPatch savegames, some compatibility settings are read from the current settings just like in TTDPatch.

No idea how to solve this conflict (loading TTO vs TTD vs TTDPatch savegames) with reasonable effort (i.e. no big import savegame GUI).

This comment was imported from FlySpray: https://bugs.openttd.org/task/4716#comment10185

@DorpsGek
Copy link
Member Author

Jubilee wrote:

Isn't there a way for OTTD to know from the file type/header what file it's loading (TTO, TTD or TTDPatch savegame) and act accordingly? For instance, if the savegame is a TTDPatch one, it could follow the "some compatibility settings are read from the current settings" rule - as you described it above, otherwise if it's TTO it could either use plain "Goto" or "Go nonstop to" since TTO does not support the "via" mode. As is now, someone new to OpenTTD thinks of this a a bug (at least i did at first). OK, since there's a workaround, it's not critical but it confuses the newbie.

An alternative could perhaps be a one-time message when loading a TTO savegame, warning the user that if the savegame contains "go nonstop" orders, they might be translated to "go nonstop via" depending on what setting they have in "new orders are non-stop by default".

This comment was imported from FlySpray: https://bugs.openttd.org/task/4716#comment10188

@DorpsGek
Copy link
Member Author

DorpsGek commented Sep 9, 2011

Rubidium closed the ticket.

Reason for closing: Fixed

In r22914

This comment was imported from FlySpray: https://bugs.openttd.org/task/4716

@DorpsGek DorpsGek closed this as completed Sep 9, 2011
@DorpsGek DorpsGek added Core flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) labels Apr 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@DorpsGek