OpenTTD

Tasklist

FS#4716 - TT savegame: "go non-stop to" translated as "go non-stop via"

Attached to Project: OpenTTD
Opened by Jubilee (Jubilee) - Monday, 08 August 2011, 14:17 GMT
Last edited by Remko Bijker (Rubidium) - Friday, 09 September 2011, 21:13 GMT
Type Bug
Category Core
Status Closed
Assigned To No-one
Operating System All
Severity Very Low
Priority Normal
Reported Version 1.1.2-RC2
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

A bug i reported in the forum (http://www.tt-forums.net/viewtopic.php?f=31&t=54580) and a workaround provided in the next post by Eddi, but it's still a bug so i'm reporting it here.

If the "new orders are 'non-stop' by default" setting is turned to ON and the attached savegame is loaded (an old TT savegame - not TTD), all "go non-stop to" orders already existing in the game are translated as "go non-stop via". On has to turn the "new orders are 'non-stop' by default" OFF before loading the game in order for train orders to be translated correctly.
This task depends upon

Closed by  Remko Bijker (Rubidium)
Friday, 09 September 2011, 21:13 GMT
Reason for closing:  Fixed
Additional comments about closing:  In r22914
Comment by frosch (frosch) - Saturday, 13 August 2011, 08:45 GMT
This is meant for loading TTDPatch savegames.

TTDPatch cannot have both "non-stop and "go-via" in a game, but has a setting to choose at startup.
I do not know whether TTDPatch stores the setting in savegames (i suspect not), but at least OpenTTD does not read it.

To still allow loading some TTDPatch savegames, some compatibility settings are read from the current settings just like in TTDPatch.

No idea how to solve this conflict (loading TTO vs TTD vs TTDPatch savegames) with reasonable effort (i.e. no big import savegame GUI).
Comment by Jubilee (Jubilee) - Saturday, 13 August 2011, 12:59 GMT
Isn't there a way for OTTD to know from the file type/header what file it's loading (TTO, TTD or TTDPatch savegame) and act accordingly? For instance, if the savegame is a TTDPatch one, it could follow the "some compatibility settings are read from the current settings" rule - as you described it above, otherwise if it's TTO it could either use plain "Goto" or "Go nonstop to" since TTO does not support the "via" mode. As is now, someone new to OpenTTD thinks of this a a bug (at least i did at first). OK, since there's a workaround, it's not critical but it confuses the newbie.

An alternative could perhaps be a one-time message when loading a TTO savegame, warning the user that if the savegame contains "go nonstop" orders, they might be translated to "go nonstop via" depending on what setting they have in "new orders are non-stop by default".

Loading...