Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hide signs of other companies #4701

Closed
DorpsGek opened this issue Jul 30, 2011 · 9 comments
Closed

Hide signs of other companies #4701

DorpsGek opened this issue Jul 30, 2011 · 9 comments
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) patch from FlySpray This issue is in fact a Patch, but imported from FlySrpay

Comments

@DorpsGek
Copy link
Member

Zuu opened the ticket and wrote:

This patch adds a setting to only show the signs that are owned by the local company.

The idea is that if someone don't like the usage of station names / signs of other companies (human or ai), they can simply hide the signs of the other companies and only show their own ones.

Question 1: Any better setting name than gui.show_only_own_signs?

Question 2: Perhaps add a menu option and/or to somehow to the transparency window? Or stick it in the advanced settings?

Attached: The patch itself and two screenshots that demonstrate the effect of the new setting.

Attachments

Reported version: Version?
Operating system: All

This issue was imported from FlySpray: https://bugs.openttd.org/task/4701
@DorpsGek
Copy link
Member Author

Zuu wrote:

This patch have a coding style issue: Two instances of "if(" that should be "if (".

A new patch has been attached with this coding style fixed. In addition the new patch hides signs from the sign list window as well as in the viewport.

Attachments

This comment was imported from FlySpray: https://bugs.openttd.org/task/4701#comment10119

@DorpsGek
Copy link
Member Author

frosch wrote:

Buoys do not have owners, so i guess they should be displayed always.

This comment was imported from FlySpray: https://bugs.openttd.org/task/4701#comment10120

@DorpsGek
Copy link
Member Author

Zuu wrote:

Hmm, also the oil rig station need to be always visible.

This comment was imported from FlySpray: https://bugs.openttd.org/task/4701#comment10121

@DorpsGek
Copy link
Member Author

Zuu wrote:

Changes:
- Only hide signs of stations that are owned by a company < MAX_COMPANIES.

Not changed:
- Waypoints. It is only that I by mistake had disabled showing all waypoint signs when I took the screenshots for the initial patch upload.

I though about if signs owned by none/town should be hidden as well, but decided that after several bankrupt companies there can often be plenty of signs that you want to hide. For stations on the other hand the signs that show are not from bankrupt companies but from neutral infrastructure.

Attachments

This comment was imported from FlySpray: https://bugs.openttd.org/task/4701#comment10122

@DorpsGek
Copy link
Member Author

Zuu wrote:

Changes:
- Use != OWNER_NONE instead of < MAX_COMPANIES.
- Added { and } for an if-statement added by the patch in signs_gui.cpp to comply with coding standard

Attachments

This comment was imported from FlySpray: https://bugs.openttd.org/task/4701#comment10124

@DorpsGek
Copy link
Member Author

DorpsGek commented Aug 1, 2011

Zuu wrote:

Changes:
- Renamed option from "show only own signs" to "show competitor signs"
- Moved option from _settings_client.gui.* to _display_opt
- New menu item in settings menu: "Show competitor signs and names"

Attached screenshot of menu item.

Reasons:
- It seems to fit well in the settings menu
- In order to make it fit better there, it has been turned into a setting with positive wording.

Attachments

This comment was imported from FlySpray: https://bugs.openttd.org/task/4701#comment10135

@DorpsGek
Copy link
Member Author

DorpsGek commented Aug 1, 2011

Zuu wrote:

Change:
- Make menu option more parallel with existing ones: "Show competitor signs and names" => "Competitor signs and names displayed"

Attachments

This comment was imported from FlySpray: https://bugs.openttd.org/task/4701#comment10136

@DorpsGek
Copy link
Member Author

DorpsGek commented Aug 1, 2011

Zuu wrote:

Change:
- Coding style fix - don't use more than one statements on a one-liner case (in a switch).

Attachments

This comment was imported from FlySpray: https://bugs.openttd.org/task/4701#comment10137

@DorpsGek
Copy link
Member Author

DorpsGek commented Aug 1, 2011

planetmaker closed the ticket.

Reason for closing: Implemented

In r22708. Thanks for the patch

This comment was imported from FlySpray: https://bugs.openttd.org/task/4701

@DorpsGek DorpsGek closed this as completed Aug 1, 2011
@DorpsGek DorpsGek added Core flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) patch from FlySpray This issue is in fact a Patch, but imported from FlySrpay labels Apr 7, 2018
@DorpsGek DorpsGek mentioned this issue Apr 7, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) patch from FlySpray This issue is in fact a Patch, but imported from FlySrpay
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@DorpsGek