Rubidium wrote:

I cannot reproduce the game even attempting to query a server without going the multiplayer game, so how can it happen in the main menu? This under the assumption that he spoke the truth when being asked whether he was in the multiplayer window.

If he was not telling the truth and he was in the multiplayer windows, then something fishy is going on w.r.t. name resolution which should not happen at all. As far as I can see the name resolution always happens in a separate thread, so the rest of the application should run fine which the name resolution is waiting for results.

This comment was imported from FlySpray: https://bugs.openttd.org/task/4697#comment10113

Rubidium closed the ticket.

Reason for closing: Fixed

In r22695

This comment was imported from FlySpray: https://bugs.openttd.org/task/4697

adf88 wrote:

Hi Rubidium, do you know what was causing the freeze? Why the name resolution wasn't done in a separate thread?

This comment was imported from FlySpray: https://bugs.openttd.org/task/4697#comment10132

Rubidium wrote:

Name resolution was, generally, done in a seperate thread. However, when name resolution failed the address would remain marked as unresolved and any other activity on said address would trigger another attempt to resolve it, which incidentally happened when trying to send some data which needs to take the mutex on the udp socket. Then the main thread would block trying to read the socket. Other cases are e.g. comparisions on addresses done when inserting it in the server list, which would trigger an unresolved address to be resolved (which would again fail).

So... the fix is easy: if resolution fails, mark it as resolved and don't try to resolve it later on. Only resolve it in the thread the next time you try to connect to it.

This comment was imported from FlySpray: https://bugs.openttd.org/task/4697#comment10134