Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rotated airports have the hangar wormhole in wrong direction #4696

Closed
DorpsGek opened this issue Jul 24, 2011 · 3 comments
Closed

Rotated airports have the hangar wormhole in wrong direction #4696

DorpsGek opened this issue Jul 24, 2011 · 3 comments
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)

Comments

@DorpsGek
Copy link
Member

Zuu opened the ticket and wrote:

How to reproduce:

- Start a game with OpenGFX+ Airports 0.2.1 or later (known as "Climate dependant airports" on Bananas)
- Build a 180 degree rotated small airport
- Build a normal oriented small airport
- Build an aircraft with orders to visit the hangar of each airport.

When the aircraft enters/leaves the hangar of the rotated airport it has to be rotated 180 degree in the wrong way.

It is true that the airplane has to turn around inside the usual non-rotated hangar, but not as much as it has to turn around in the rotated one.

OpenTTD Version:
nightly 22683
win32

OS: Windows Vista

Reported version: trunk
Operating system: All

This issue was imported from FlySpray: https://bugs.openttd.org/task/4696
@DorpsGek
Copy link
Member Author

Alberth wrote:

If you make the airport transparent, you can see that the airplane enters, rotates 180 degrees, gets set with its nose in the direction of entering, and rotates 180 degrees again before exiting the hangar.

The code responsible for this is

void AircraftLeaveHangar(Aircraft *v) in src/aircraft_cmd.cpp, line 1251, sets v->direction = DIR_SE;

DIR_SE is the right direction to leave the hangar in unrotated airports, but obviously the wrong direction for rotated airports.

This comment was imported from FlySpray: https://bugs.openttd.org/task/4696#comment10131

@DorpsGek
Copy link
Member Author

Alberth wrote:

The attached patch fixes plane rotation for the rotated default airports.
It will break for hangars with a different orientation, ie in newgrf airports.

Attachments

This comment was imported from FlySpray: https://bugs.openttd.org/task/4696#comment10133

@DorpsGek
Copy link
Member Author

Alberth closed the ticket.

Reason for closing: Fixed

A more generic solution has been committed in r22743

This comment was imported from FlySpray: https://bugs.openttd.org/task/4696

@DorpsGek DorpsGek added Core flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) labels Apr 7, 2018
@DorpsGek DorpsGek mentioned this issue Apr 7, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@DorpsGek